Skip to content

tests: Allow valid Timeout result #13154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spencer-lunarg wants to merge 1 commit into from
+1 −1
Closed

tests: Allow valid Timeout result #13154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/unit/other_positive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ TEST_F(PositiveOther, GetDeviceFaultReportsWithoutTimeout) {
RETURN_IF_SKIP(Init());
uint32_t fault_counts = 0;
VkResult result = vk::GetDeviceFaultReportsKHR(device(), 0, &fault_counts, nullptr);
ASSERT_EQ(VK_SUCCESS, result);
ASSERT_TRUE(result == VK_TIMEOUT || result == VK_SUCCESS);

@artem-lunarg artem-lunarg Sep 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this test then? it's called GetDeviceFaultReportsWithoutTimeout

@spencer-lunarg spencer-lunarg Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to talk with Samual again.... the whole ShaderAbort thing has been a disaster IMO, and seems a lack of testing/agreement how these device faults should work

... closing and going to figure this out

ASSERT_EQ(fault_counts, 0);
}

Expand Down
Loading