sync: Merge ranges during update - #13156
Merged
artem-lunarg merged 2 commits intoSep 18, 2026
Merged
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 124426. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24566 running. |
artem-lunarg
marked this pull request as ready for review
September 18, 2026 17:01
spencer-lunarg
approved these changes
Sep 18, 2026
artem-lunarg
force-pushed
the
artem-sync-merge-ranges
branch
from
September 18, 2026 18:19
3378e4a to
e59595b
Compare
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 124545. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24571 running. |
Collaborator
|
CI Vulkan-ValidationLayers build # 24571 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have existing code that merges access ranges during submit, but for new validation it is also benefitial to merge early (reproduciable with doom dark ages).
This happens because record time validation always starts with an empty access map. The new full validation mode can inherent fragmented access map from the previous submission and it's good for performance to detect early merge opportunities.
This fixed performance issue in doom darm ages (now with full validation it runs a bit faster than old record+submit mode) and also dota2 capture got 25% speed up.