Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preparing a new morph repeatedly recalculated contour metrics and pair costs during assignment. Precompute them once while preserving correspondence order and visual output. Synthetic AOT measurements on Windows show a six-contour plan improving from 441.6 to 65.1 microseconds (median p50 across three runs).
Add
precacheMorphfor explicit preparation in the existing configurable cache andonFallbackdiagnostics on both widgets, including release builds. Add CPU/frame-timing harnesses and a reproducible visual A/B capture test. Defaults and animation trajectories remain unchanged.Verification
361f54d: 108 paired captures / 3,600 icon frames / 147,456,000 RGBA pixels, zero differences without tolerance. Includes controlled progress, sizes, DPR, RTL, shadows and repeated spring interruptions. Contact sheets also inspected visually.