test(scripts): lock header-order update failures

The updater's checks never ran in the suite, so inverting them stayed
green. Importing the script no longer fetches, a failed cleanup keeps
the original write error, and each new check now has a test that fails
when it is inverted.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Kikobeats

scripts/update-headers-order.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { writeFile, rename, rm } = require('fs/promises')
+const fs = require('fs/promises')
 const path = require('path')
 
 const SOURCE_URL =
@@ -28,25 +28,30 @@ const assertHeadersOrder = headersOrder => {
   return headersOrder
 }
 
-const writeAtomically = async (destination, content) => {
+const writeAtomically = async (destination, content, io = fs) => {
   const temporary = `${destination}.${process.pid}.tmp`
   try {
-    await writeFile(temporary, content)
-    await rename(temporary, destination)
+    await io.writeFile(temporary, content)
+    await io.rename(temporary, destination)
   } catch (error) {
-    await rm(temporary, { force: true })
+    // A cleanup failure must not replace the write or rename error.
+    await io.rm(temporary, { force: true }).catch(() => {})
     throw error
   }
 }
 
-const main = async () => {
-  const response = await fetch(SOURCE_URL)
-  if (!response.ok) throw new Error(`HTTP ${response.status} for ${SOURCE_URL}`)
+const main = async ({ destination = DESTINATION, url = SOURCE_URL } = {}) => {
+  const response = await fetch(url)
+  if (!response.ok) throw new Error(`HTTP ${response.status} for ${url}`)
   const headersOrder = assertHeadersOrder(await response.json())
-  await writeAtomically(DESTINATION, JSON.stringify(headersOrder, null, 2))
+  await writeAtomically(destination, JSON.stringify(headersOrder, null, 2))
 }
 
-main().catch(error => {
-  console.error(error)
-  process.exitCode = 1
-})
+if (require.main === module) {
+  main().catch(error => {
+    console.error(error)
+    process.exitCode = 1
+  })
+}
+
+module.exports = { assertHeadersOrder, main, writeAtomically }

test/package.js

@@ -10,7 +10,7 @@ const INSTALL_LIFECYCLE_SCRIPTS = ['preinstall', 'install', 'postinstall']
 
 const packedFiles = () => {
   const [{ files }] = JSON.parse(
-    execFileSync('npm', ['pack', '--dry-run', '--json', '--ignore-scripts'], {
+    execFileSync('npm', ['pack', '--dry-run', '--json'], {
       cwd: path.join(__dirname, '..'),
       encoding: 'utf8'
     })
@@ -30,3 +30,14 @@ test('the published package ships the headers order data and no release scripts'
   t.true(files.includes('src/headers-order.json'))
   t.false(files.some(file => file.startsWith('scripts/')))
 })
+
+test('release refreshes header order before testing and stages it only after a successful update', t => {
+  t.is(
+    pkg.scripts.prerelease,
+    'npm run contributors && npm run update:headers-order && npm test'
+  )
+  t.is(
+    pkg.scripts['update:headers-order'],
+    'node scripts/update-headers-order.js && git add src/headers-order.json'
+  )
+})