Repository navigation
ci: add weekly cron to refresh headers-order.json - #30
Merged
Merged
Conversation
Same shape as country-vat: run the postinstall fetcher, gate on the test suite, commit `build(update): headers order` only when the file changed, push with GH_TOKEN so main.yml releases the new data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
https-tls
Details
| Benchmark suite | Current: cc01773 | Previous: 6bae081 | Ratio |
|---|---|---|---|
sortHeaders chrome |
103.6 ms (103.3-103.9) |
103.9 ms (103.2-104.8) |
1.00 |
sortHeaders firefox |
90.5 ms (90.2-91.3) |
90.1 ms (89.7-91.4) |
1.00 |
sortHeaders safari |
87.9 ms (87.3-89.2) |
87.5 ms (86.5-89) |
1.00 |
getBrowser top 100 user agents |
324.2 ms (322.1-327.4) |
324.3 ms (323.9-328.3) |
1.00 |
tls options top 100 user agents |
273.3 ms (257.5-275.6) |
261.1 ms (259.1-273.7) |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
Coverage Report for CI Build 40734249320Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 99.653%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
A failed fetch (offline install, upstream down) used to exit 1 and break `npm install https-tls`. It now warns and keeps the bundled file. The cron runs it with --strict so a broken fetch still fails the job and skips the healthcheck ping instead of passing silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/cron.yml, a weekly job (Monday 00:00 UTC, plus manualworkflow_dispatch) that refreshessrc/headers-order.json, using the same pattern ascountry-vat/free-email-domains:npm run postinstallfetches the upstream file fromapify/fingerprint-suitenpm testruns, so if upstream changes its format the job fails before anything reaches masterbuild(update): headers orderonly when the file actually changedgit push origin HEADusingGH_TOKEN, so the push triggersmain.ymland that publishes a releaseNote on "outdated"
Today the local file matches upstream byte for byte (checked against raw.githubusercontent.com, not only the githack cache). Upstream pushed a model update on 2026-08-01 and reverted it on 2026-08-05 (apify/fingerprint-suite#565), so the current source data is the June 2025 data again. This cron picks up the next upstream update automatically.
Tested
build(update): headers ordercommit that restores upstream.actionlintpasses. I replacedgithub.head_ref, which is empty onscheduleand which actionlint flags as an injection risk, withHEAD.npm test: 20 passed.Postinstall
The postinstall now warns instead of exiting 1, so an offline or failed fetch no longer breaks
npm install https-tls; users keep the bundled file. The cron runsnode scripts/postinstall.js --strict, which still exits 1, so a broken fetch fails the job and skips the healthcheck ping.Follow-up
Healthcheck ping added after a successful run.
🤖 Generated with Claude Code
Note
Medium Risk
Automated commits and pushes to the default branch depend on secrets and upstream fetch reliability, though tests run before any commit.
Overview
Adds a scheduled GitHub Actions workflow (Mondays 00:00 UTC, plus manual dispatch) that refreshes
src/headers-order.jsonfrom upstreamapify/fingerprint-suite, runsnpm test, commitsbuild(update): headers orderonly when the file changes, pushes withGH_TOKEN, and pings a healthcheck on success.scripts/postinstall.jsnow accepts--strict: normal installs warn and keep the bundled file if the fetch fails; the cron invokesnode scripts/postinstall.js --strictso a failed update fails the job instead of silently continuing.Reviewed by Cursor Bugbot for commit cc01773. Bugbot is set up for automated code reviews on this repo. Configure here.