Reduce size of Kilt JAR by around 20MB - #974
Draft
a6tumn wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This change depends on Add publishing block for root project Fabricators-of-Create/Porting-Lib#201 being merged.
The final Maven coordinates of the published artifact will likely change.
Explanation
Many of Porting Lib's modules include their own dependencies, and Loom does not have a method of deduplicating second-level nested dependencies as far as I know. This can lead to less than optimal file sizes for any mod that includes a lot of modules.
I tested the functionality by building Porting Lib locally, and Kilt locally using the setup from this PR. I was able to get a Kilt build to around 16.5MB in size that worked flawlessly with the latest Twilight Forest NeoForge build. I have also tested building Twilight Forest on Fabric with a similar Porting Lib setup and was able to reduce the size of the built JAR by around 12MB.