Add e2e:web:webkit tests for Safari coverage - #13640
Draft
pierremtb wants to merge 13 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacebrowning
reviewed
Sep 4, 2026
jacebrowning
reviewed
Sep 4, 2026
pierremtb
changed the title
jacebrowning
reviewed
Sep 4, 2026
Contributor
|
If we can't get the tests passing, it might still be worth it to ship all of these changes anyway with just the CI matrix variant disabled for now. That will enable local testing with Safari. |
Contributor
Author
|
Yeah I don't hate that idea! I see lots of failures on many PRs right now, might due to the dev outage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in https://kittycadworkspace.slack.com/archives/C06L2RHP9SL/p1788484918078329?thread_ts=1788475120.909939&cid=C06L2RHP9SL, Safari represents a sizeable browser share in our web users, free and paid, so we need to test against it alongside Chrome. Firefox is still low enough for now.
Snapshot coverage is split into the stacked follow-up #13643.