Plan variable-less selection inputs without collapsing pipes - #13645
Draft
pierremtb wants to merge 8 commits into
Draft
Plan variable-less selection inputs without collapsing pipes#13645pierremtb wants to merge 8 commits into
pierremtb wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pierremtb
force-pushed
the
codex/selection-input-planning
branch
from
September 4, 2026 20:08
f210ca5 to
b7434a9
Compare
pierremtb
changed the base branch from
pierremtb/codex-preserve-codemod-selections
to
codex/skip-edit-selection-reconstruction
September 4, 2026 20:09
pierremtb
force-pushed
the
codex/selection-input-planning
branch
from
September 4, 2026 21:31
b7434a9 to
38f8f03
Compare
pierremtb
changed the base branch from
codex/skip-edit-selection-reconstruction
to
codex/preserve-edit-selection-arguments
September 4, 2026 21:31
pierremtb
force-pushed
the
codex/selection-input-planning
branch
2 times, most recently
from
September 5, 2026 10:39
757a1eb to
e7a7d53
Compare
pierremtb
force-pushed
the
codex/preserve-edit-selection-arguments
branch
from
September 5, 2026 11:03
d91c367 to
ca465c3
Compare
pierremtb
force-pushed
the
codex/selection-input-planning
branch
from
September 5, 2026 11:03
e7a7d53 to
5d3b287
Compare
pierremtb
force-pushed
the
codex/preserve-edit-selection-arguments
branch
from
September 5, 2026 11:06
ca465c3 to
81b0ca8
Compare
pierremtb
force-pushed
the
codex/selection-input-planning
branch
from
September 5, 2026 11:06
5d3b287 to
e67bca2
Compare
# Conflicts: # src/lang/modifyAst/transforms.ts
# Conflicts: # src/lang/modifyAst/transforms.ts
pierremtb
force-pushed
the
codex/preserve-edit-selection-arguments
branch
from
September 5, 2026 11:12
81b0ca8 to
87bd927
Compare
pierremtb
force-pushed
the
codex/selection-input-planning
branch
from
September 5, 2026 11:12
e67bca2 to
c5b979a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #13662.
Introduces a shared selection-input plan that keeps each selected source pipe distinct until the codemod decides whether it can stay inline or must be materialized.
Migrates Translate, Rotate, Scale, Appearance, Mirror 3D, Hide, and Delete to the shared planner. A single variable-less input still stays in its source pipe; multiple source pipes are assigned stable names so every selected body remains represented.
Edit calls still reconstruct selections for dialogs and future true selection edits, but the planner returns before materializing or rerouting those inputs. This layer changes creation behavior only.
This is intentionally the narrow foundation for the stack. Clone, Boolean, Sweep, and plane selection migrations are left to the next PR so reviewers can evaluate the representation and materialization rules before the broader adoption.
Supersedes the overlapping one-off fixes in #13408 and #13417.
Fixes #13407.
Fixes #13416.
Fixes #13418.
Risk: converting multiple bare source expressions into declarations changes formatting and introduces generated names. Comments are carried onto the replacement declarations.