fix: handle None timezone_offset in timestamp formatting - #208
Open
saschabuehrle wants to merge 1 commit into
Open
fix: handle None timezone_offset in timestamp formatting#208saschabuehrle wants to merge 1 commit into
saschabuehrle wants to merge 1 commit into
Conversation
Owner
|
Hi, just checking, did the fix in #206 not solve it on your end? Happy to dig back into it if it's still acting up. |
Author
|
Yeah, #206 fixes one path, but this PR covers another failing case where timezone_offset can still be None in imports. I hit that on a converted export and this guard prevents the timedelta(None) crash there too.\n\nGreetings, saschabuehrle |
Owner
|
I ran your |
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
Timing.format_timestamp()acceptedOptional[int]fortimezone_offset, but it always instantiatedTimeZone(self.timezone_offset). When the offset wasNone, this crashed intimedelta(hours=None).This keeps the existing timezone path for integer offsets and uses plain
datetime.fromtimestamp()when offset isNone. Added a regression test for theNonecase.Greetings, saschabuehrle