Repository navigation
Conversation
Clarify behavior on token exchange failure and logging.
馃懛 Deploy request for kongdeveloper pending review.Visit the deploys page to approve it
|
Update logging and timeout behavior for token endpoint failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify behavior on token exchange failure and logging.
Description
Fixes #7529
Adds one paragraph to "How token exchange works": a failed exchange (token endpoint refusal, 5xx, or unreachable) returns
401witherror="invalid_token"to the client, the token endpoint status is only in the data plane log, and an unreachable endpoint answers afterconfig.timeout.Observed on Kong Gateway Enterprise 3.14.0.15, self-managed data plane, four runs; the full table is in the issue. The paragraph says "about twice config.timeout (measured; see #7529)" because, when the token endpoint didn't answer, Kong sent a second token request (details and a question in the issue). Please confirm the behaviour on 3.15 and 3.16 before merging. If it differs by version, the paragraph may need a version note.
Preview Links
https://deploy-preview-7531--kongdeveloper.netlify.app/plugins/openid-connect/#token-exchange
Checklist
config.timeoutreference.)descriptionentry in frontmatter. (Unchanged.)