Repository navigation
fix(dcgw): add request to get the VPC ID for TGW - #7568
Merged
Merged
Conversation
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
cloudjumpercat
marked this pull request as ready for review
October 14, 2026 13:43
Contributor
|
✅ KSAI Review: Finished Run report (federated) · 1 paid run · $0.1436 total
Reviewing cost $0.1436 |
![kong-ksai[bot]](https://avatars.githubusercontent.com/in/4495376?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | One docs page: the AWS Transit Gateway setup list and a new step that looks up each network's VPC ID. |
| Mandate | default-code-review |
| Findings | 1 Low |
| Findings audit | Independent audit completed: verified both cited lines, the spec field and the sibling patterns, upheld the one Low dedupe finding with tighter wording, and found no escaped bugs. |
The change is documentation-only: it flattens the AWS Transit Gateway setup list and adds a step that resolves each network's Kong-side VPC ID. The new request matches the get-network operation and the provider_metadata.vpc_id field in the Cloud Gateways spec.
No additional concerns found.
lena-larionova
approved these changes
Oct 20, 2026
lena-larionova
left a comment
lena-larionova
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one nit, and it's worth accepting the fix from ksai.
Co-authored-by: kong-ksai[bot] <313415923+kong-ksai[bot]@users.noreply.github.com> Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://kongstrong.slack.com/archives/CDSTDSG9J/p1791398170952379
Preview Links
https://deploy-preview-7568--kongdeveloper.netlify.app/dedicated-cloud-gateways/transit-gateways/#accept-the-transit-gateway-attachment-in-aws
Checklist
descriptionentry in frontmatter.