Repository navigation
Fix listItem.name in structured data - #7646
Merged
Merged
Conversation
Contributor
|
✅ KSAI Review: Finished Run report (federated) · 1 paid run · $0.1402 total
Reviewing cost $0.1402 |
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![kong-ksai[bot]](https://avatars.githubusercontent.com/in/4495376?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | Jekyll Liquid include that builds BreadcrumbList JSON-LD; one ListItem name value changed |
| Mandate | default-code-reviewer |
| Findings | 1 Medium |
| Findings audit | Independent audit completed: upheld the Medium, verified the raw-text trigger and the generating plugin page, and corrected the wording; nothing removed or added. |
The Medium is right-sized: the change keeps the JSON-LD block valid for quoted titles, but the HTML escaper writes entity text into a raw-text script, so names publish wrong. Titles with &, ', < or > are affected. Use a JSON filter on both name lines.
Additional Risk pass: no secret, injection, or resource issue; the diff changes one include line.
Co-authored-by: kong-ksai[bot] <313415923+kong-ksai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with double quotes in listItem's name in structured data
Preview Links
Checklist
descriptionentry in frontmatter.