Repository navigation
fix(http1.1): compute Content-Length as a utf8 byte length - #394
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
|
erunion
approved these changes
Nov 5, 2026
Author
|
@erunion CLA signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content-LengthusesBuffer.byteLength(text, 'ascii'), which counts UTF-16 code units instead of bytes, so atext/plainbody ofäöüis 6 bytes on the wire but rendersContent-Length: 3.erunion diagnosed this in #332 on 2023-11-03, pointing at this line and the
asciiencoding. Switching the encoding toutf8is the whole fix.The test drives
HTTPSnippet.convertfor thehttp/http1.1client with a non-ascii body. Every body undersrc/fixtures/requestsis ascii, where the two encodings agree, so nothing existing moved: 747 tests before, 748 after.Fixes #332