Skip to content

test(durable): unblock the merge queue on callback mutants and msgpack #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swkeever merged 2 commits into from
Oct 27, 2026
Merged

test(durable): unblock the merge queue on callback mutants and msgpack #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d0a13e
test(durable): close the hand-off coroutine when the refusal is missing
swkeever Oct 27, 2026
dd3b479
chore(deps-dev): bump msgpack to 1.2.4
swkeever Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/volcano_sdk/_tests/test_durable_callback_token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,17 @@ def hand_off(token: str) -> Coroutine[object, object, None]:

submit = token_submitter(API_URL, "arn:execution", "payment", hand_off)

with pytest.raises(TypeError, match=SYNCHRONOUS):
submit("callback-4", None)
# Read the state, then close the coroutine either way: one left unclosed
# when the refusal is missing outlives the test and fails the session.
try:
with pytest.raises(TypeError, match=SYNCHRONOUS):
submit("callback-4", None)
finally:
states = [inspect.getcoroutinestate(coroutine) for coroutine in started]
for coroutine in started:
coroutine.close()
assert handed == []
[coroutine] = started
assert inspect.getcoroutinestate(coroutine) == inspect.CORO_CLOSED
assert states == [inspect.CORO_CLOSED]


class Pending:
Expand Down
Loading
Loading