Conversation
Improve tag handling and error management: - Changed string comparison to be case-sensitive to increase the number of usable tags - Find the possible tag occurrences more accurate, if multiple identical tags are found on the same line - Fix undo bug if e.g. a tag is not found (using `finally`) In addition, the Revision number has been increased
|
Looks good, thanks. I will merge it without the tag so the 32-bit file number can be synchronized (see the resource and version string files). Since I'm not using the plugin myself, and it's best to keep releases in one place, I'd be happy to transfer the repo to your account if you want. All you have to do is rename your fork to free up the "WebEdit" name, then wait for a transfer invite. After the transfer, requests for "npp-dotnet/WebEdit" should be automatically redirected — smooth continuity for current users, no more PR hassle to publish new improvements 😎 |
|
Thanks for the tip, I'll keep an eye out for (32-bit) resource and version number files in the future! It's an honor to be asked to maintain the repo! Since I'm primarily a web (PHP) developer and use the plugin regularly, I'll try to improve it further in the spirit of previous developments, in addition to fixing other possible bugs. I renamed the forked repo to WebEditForked, so the WebEdit name is theoretically freed up. I look forward to the invitation! :) |
|
Sorry, looks like I spoke too soon 😊 Here are the remaining obstacles to making the transfer.
|
|
Thanks for the instructions! I had to swap the two steps and (as you can see) the transfer worked perfectly. 👌 I hope I can figure out something about the licensing issue, although since other plugins use |
Improve tag handling and error management:
finally)In addition, the Revision number has been increased
There is no issue associated with this PR.