Skip to content

Minor bug fixes and upgrades - #2

Merged
rdipardo merged 1 commit into
masterfrom
master
Sep 13, 2025
Merged

Minor bug fixes and upgrades#2
rdipardo merged 1 commit into
masterfrom
master

Conversation

@Krazal

@Krazal Krazal commented Sep 12, 2025

Copy link
Copy Markdown
Owner

Improve tag handling and error management:

  • Changed string comparison to be case-sensitive to increase the number of usable tags
  • Find the possible tag occurrences more accurate, if multiple identical tags are found on the same line
  • Fix undo bug if e.g. a tag is not found (using finally)

In addition, the Revision number has been increased

There is no issue associated with this PR.

Improve tag handling and error management:
- Changed string comparison to be case-sensitive to increase the number of usable tags
- Find the possible tag occurrences more accurate, if multiple identical tags are found on the same line
- Fix undo bug if e.g. a tag is not found (using `finally`)

In addition, the Revision number has been increased
@Krazal Krazal mentioned this pull request Sep 12, 2025
@rdipardo

Copy link
Copy Markdown

Looks good, thanks. I will merge it without the tag so the 32-bit file number can be synchronized (see the resource and version string files).

Since I'm not using the plugin myself, and it's best to keep releases in one place, I'd be happy to transfer the repo to your account if you want. All you have to do is rename your fork to free up the "WebEdit" name, then wait for a transfer invite.

After the transfer, requests for "npp-dotnet/WebEdit" should be automatically redirected — smooth continuity for current users, no more PR hassle to publish new improvements 😎

@rdipardo
rdipardo merged commit 5a52584 into Krazal:master Sep 13, 2025
4 checks passed
@Krazal

Krazal commented Sep 15, 2025

Copy link
Copy Markdown
Owner Author

Thanks for the tip, I'll keep an eye out for (32-bit) resource and version number files in the future!

It's an honor to be asked to maintain the repo! Since I'm primarily a web (PHP) developer and use the plugin regularly, I'll try to improve it further in the spirit of previous developments, in addition to fixing other possible bugs.

I renamed the forked repo to WebEditForked, so the WebEdit name is theoretically freed up. I look forward to the invitation! :)

@rdipardo

rdipardo commented Sep 15, 2025

Copy link
Copy Markdown

Sorry, looks like I spoke too soon 😊

Here are the remaining obstacles to making the transfer.

  • Permission. The user making the transfer needs write access to both the target and the destination account(?!).
    I invited you to be an owner of the npp-dotnet org; after that, you should have the required access level. Once a member, try starting the transfer by going to https://github.com/npp-dotnet/WebEdit/settings and clicking the red Transfer button.

  • The fork network. So, renaming your existing fork is not enough; the transferred repo needs to be the one and only fork in the target account. Don't delete anything yet; first go to your fork's settings page and clicking the red Leave fork network button. Do this before someone forks your fork, or this option will be blocked 🙄

@Krazal

Krazal commented Sep 16, 2025

Copy link
Copy Markdown
Owner Author

Thanks for the instructions!

I had to swap the two steps and (as you can see) the transfer worked perfectly. 👌

I hope I can figure out something about the licensing issue, although since other plugins use NotepadPlusPlusPluginPack.Net, I think there's a chance this plugin might get added to the nppPluginList. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants