From 2800c1a75e111ede1588c07b202f86f0aa79857c Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:29:18 -0700 Subject: [PATCH 1/9] Move to lbug 0.22.0 (arrow stays pinned at 55) lbug 0.22.x still builds its Arrow batches with arrow 55, so the arrow/arrow-flight pins and the arrow56 icebug alias are unchanged. Vendored liblbug.dylib refreshed to the 0.22.0 osx-arm64 release (gitignored liblbug/). --- Cargo.lock | 4 ++-- Cargo.toml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 4cf5e7a..cb1f8e2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3568,9 +3568,9 @@ dependencies = [ [[package]] name = "lbug" -version = "0.21.2" +version = "0.22.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "862a51324bf4785f3f1e4dca9b86d38745b543c0f06b1a5731956e66979879c3" +checksum = "ba8edc9b2a2efaed69ae879971a7d9690e771b10492b6a4082aeea88acf3c84b" dependencies = [ "arrow 55.2.0", "cmake", diff --git a/Cargo.toml b/Cargo.toml index 2d83f3d..eebd32d 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -9,9 +9,9 @@ icebug-analytics = ["dep:icebug"] [dependencies] gpui = "0.2" -lbug = { version = "0.21.2", features = ["arrow"] } +lbug = { version = "0.22.0", features = ["arrow"] } icebug = { version = "=13.2.0", optional = true } -# Pinned to 55 to match lbug's `arrow` (0.21.x uses arrow 55): lbug hands us +# Pinned to 55 to match lbug's `arrow` (0.21.x/0.22.x use arrow 55): lbug hands us # Arrow batches built with its own arrow, so our decode types must be the # same crate version or every `downcast_ref` silently yields nothing. arrow = { version = "55", default-features = false, features = ["ffi", "prettyprint"] } From 94e5175b60806ac74f2ec1aa8a0c5212f90374d0 Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:29:22 -0700 Subject: [PATCH 2/9] Pin icebug prebuilt 13.5 on Linux, keep 13.4 elsewhere The Linux CI pairs the 0.22.0 algo extension (which needs NetworKit symbols introduced after 13.2) with the 13.5 prebuilt; macOS/Windows stay on 13.4. Overridable per run via ICEBUG_VERSION. --- scripts/download_icebug.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/scripts/download_icebug.sh b/scripts/download_icebug.sh index e13e62f..2256a56 100755 --- a/scripts/download_icebug.sh +++ b/scripts/download_icebug.sh @@ -12,11 +12,20 @@ PROJECT_DIR="$(cd "$SCRIPT_DIR/.." && pwd)" REPOSITORY="${ICEBUG_GITHUB_REPOSITORY:-Ladybug-Memory/icebug}" TARGET_DIR="${ICEBUG_TARGET_DIR:-$PROJECT_DIR/icebug}" -VERSION="${ICEBUG_VERSION:-13.4}" OS="$(uname -s)" ARCH="$(uname -m)" +# Linux CI pairs the 0.22.0 algo extension with NetworKit 13.5 (its +# prebuilt links libarrow.so.2600, hence the Arrow 26 apt pin in CI); +# macOS/Windows stay on 13.4 with the Arrow 25 setup. Overridable per +# run via ICEBUG_VERSION. +case "$OS" in + Linux) DEFAULT_VERSION="13.5" ;; + *) DEFAULT_VERSION="13.4" ;; +esac +VERSION="${ICEBUG_VERSION:-$DEFAULT_VERSION}" + case "$OS" in Darwin) ASSET_OS="macos" From 129d64f21d76119ecf2206f8e1398097ce6d00f8 Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:29:48 -0700 Subject: [PATCH 3/9] CI Linux: Arrow 26 for the icebug 13.5 prebuilt The Linux 13.5 prebuilt links libarrow.so.2600; pin both apt blocks to libarrow-dev/libarrow2600 26.0.0-1 (macOS keeps its Arrow 25 install, matching the 13.4 prebuilt there). --- .github/workflows/build.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e39175d..829fbd7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,13 +36,13 @@ jobs: wget -qO- --timeout=60 --tries=3 https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/llvm-snapshot.asc echo "deb http://apt.llvm.org/jammy llvm-toolchain-jammy-20 main" | sudo tee /etc/apt/sources.list.d/llvm20.list # Apache Arrow repo (icebug's cxx bridge needs arrow headers). - # Pinned to 25.0.1: the icebug prebuilt links libarrow.so.2500; the - # repo now defaults to 26.x, which breaks test/runtime loads. + # Pinned to 26.0.0 to match the Linux icebug 13.5 prebuilt, which + # links libarrow.so.2600 (macOS stays on Arrow 25 + icebug 13.4). wget --timeout=60 --tries=3 https://apache.jfrog.io/artifactory/arrow/ubuntu/apache-arrow-apt-source-latest-jammy.deb sudo apt-get install -y ./apache-arrow-apt-source-latest-jammy.deb # Bound mirror stalls: fail fast instead of hanging the run for hours. sudo apt-get -o Acquire::Retries=3 -o Acquire::http::Timeout=60 -o Acquire::https::Timeout=60 update - sudo apt-get -o Acquire::Retries=3 -o Acquire::http::Timeout=60 -o Acquire::https::Timeout=60 install -y --no-install-recommends gcc-13 g++-13 cmake pkg-config libssl-dev libxkbcommon-dev libxkbcommon-x11-dev libwayland-dev libarrow-dev=25.0.1-1 libarrow2500=25.0.1-1 libomp-20-dev + sudo apt-get -o Acquire::Retries=3 -o Acquire::http::Timeout=60 -o Acquire::https::Timeout=60 install -y --no-install-recommends gcc-13 g++-13 cmake pkg-config libssl-dev libxkbcommon-dev libxkbcommon-x11-dev libwayland-dev libarrow-dev=26.0.0-1 libarrow2600=26.0.0-1 libomp-20-dev echo "CC=gcc-13" >> "$GITHUB_ENV" echo "CXX=g++-13" >> "$GITHUB_ENV" @@ -160,13 +160,13 @@ jobs: wget -qO- --timeout=60 --tries=3 https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/llvm-snapshot.asc echo "deb http://apt.llvm.org/jammy llvm-toolchain-jammy-20 main" | sudo tee /etc/apt/sources.list.d/llvm20.list # Apache Arrow repo (icebug's cxx bridge needs arrow headers). - # Pinned to 25.0.1: the icebug prebuilt links libarrow.so.2500; the - # repo now defaults to 26.x, which breaks test/runtime loads. + # Pinned to 26.0.0 to match the Linux icebug 13.5 prebuilt, which + # links libarrow.so.2600 (macOS stays on Arrow 25 + icebug 13.4). wget --timeout=60 --tries=3 https://apache.jfrog.io/artifactory/arrow/ubuntu/apache-arrow-apt-source-latest-jammy.deb sudo apt-get install -y ./apache-arrow-apt-source-latest-jammy.deb # Bound mirror stalls: fail fast instead of hanging the run for hours. sudo apt-get -o Acquire::Retries=3 -o Acquire::http::Timeout=60 -o Acquire::https::Timeout=60 update - sudo apt-get -o Acquire::Retries=3 -o Acquire::http::Timeout=60 -o Acquire::https::Timeout=60 install -y --no-install-recommends gcc-13 g++-13 cmake pkg-config libssl-dev libxkbcommon-dev libxkbcommon-x11-dev libwayland-dev libarrow-dev=25.0.1-1 libarrow2500=25.0.1-1 libomp-20-dev + sudo apt-get -o Acquire::Retries=3 -o Acquire::http::Timeout=60 -o Acquire::https::Timeout=60 install -y --no-install-recommends gcc-13 g++-13 cmake pkg-config libssl-dev libxkbcommon-dev libxkbcommon-x11-dev libwayland-dev libarrow-dev=26.0.0-1 libarrow2600=26.0.0-1 libomp-20-dev echo "CC=gcc-13" >> "$GITHUB_ENV" echo "CXX=g++-13" >> "$GITHUB_ENV" From fc7c660725f9b447d70d2fcb257be2bf7d321680 Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:29:54 -0700 Subject: [PATCH 4/9] Vendored-first rpath order on macOS MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit /opt/homebrew entries preceded the @executable_path ones, so an ambient Homebrew ladybug 0.20.0 (and its stale libnetworkit) shadowed the pinned ./liblbug and ./icebug prebuilts at load time — crashing with ABI skew instead of using the vendored libs. Vendored dirs now resolve first; Homebrew/system entries remain as fallback for arrow and libomp, matching the Linux sections' existing order. --- .cargo/config.toml | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/.cargo/config.toml b/.cargo/config.toml index 4fcaf44..6714d9b 100644 --- a/.cargo/config.toml +++ b/.cargo/config.toml @@ -20,19 +20,17 @@ ICEBUG_DIR = { value = "icebug", relative = true } # - macOS .app bundles stage them under Contents/Frameworks # - cargo dev/test binaries resolve ../../../ entries # (target/{debug,release}/deps/ -> repo root) -# Absolute well-known rpaths (macOS only): the algo extension is downloaded -# at runtime and its own LC_RPATHs point at its build machine, so its -# @rpath deps (libarrow, libomp, libnetworkit) expand against *this* -# binary's rpaths. These entries let it resolve from Homebrew / system -# locations with no DYLD_LIBRARY_PATH. Missing dirs are harmless. +# Vendored dirs come first so the pinned prebuilts (./liblbug, +# ./icebug/lib) always win over ambient copies (e.g. a Homebrew +# ladybug/libnetworkit): an incompatible ambient lib resolved first +# segfaults (lbug) or fails LOAD (algo extension) with no graceful +# error. Absolute well-known rpaths (macOS only) follow: the algo +# extension is downloaded at runtime and its own LC_RPATHs point at its +# build machine, so its @rpath deps (libarrow, libomp) expand against +# *this* binary's rpaths. These entries let it resolve from Homebrew / +# system locations with no DYLD_LIBRARY_PATH. Missing dirs are harmless. [target.aarch64-apple-darwin] rustflags = [ - "-C", "link-arg=-Wl,-rpath,/opt/homebrew/lib", - "-C", "link-arg=-Wl,-rpath,/opt/homebrew/opt/apache-arrow/lib", - "-C", "link-arg=-Wl,-rpath,/opt/homebrew/opt/libomp/lib", - "-C", "link-arg=-Wl,-rpath,/usr/local/lib", - "-C", "link-arg=-Wl,-rpath,/usr/local/opt/apache-arrow/lib", - "-C", "link-arg=-Wl,-rpath,/usr/local/opt/libomp/lib", "-C", "link-arg=-Wl,-rpath,@executable_path", "-C", "link-arg=-Wl,-rpath,@executable_path/icebug/lib", "-C", "link-arg=-Wl,-rpath,@executable_path/liblbug", @@ -44,16 +42,16 @@ rustflags = [ "-C", "link-arg=-Wl,-rpath,@executable_path/../../../../liblbug", "-C", "link-arg=-Wl,-rpath,@executable_path/../../../icebug/lib", "-C", "link-arg=-Wl,-rpath,@executable_path/../../../../icebug/lib", -] - -[target.x86_64-apple-darwin] -rustflags = [ "-C", "link-arg=-Wl,-rpath,/opt/homebrew/lib", "-C", "link-arg=-Wl,-rpath,/opt/homebrew/opt/apache-arrow/lib", "-C", "link-arg=-Wl,-rpath,/opt/homebrew/opt/libomp/lib", "-C", "link-arg=-Wl,-rpath,/usr/local/lib", "-C", "link-arg=-Wl,-rpath,/usr/local/opt/apache-arrow/lib", "-C", "link-arg=-Wl,-rpath,/usr/local/opt/libomp/lib", +] + +[target.x86_64-apple-darwin] +rustflags = [ "-C", "link-arg=-Wl,-rpath,@executable_path", "-C", "link-arg=-Wl,-rpath,@executable_path/icebug/lib", "-C", "link-arg=-Wl,-rpath,@executable_path/liblbug", @@ -65,6 +63,12 @@ rustflags = [ "-C", "link-arg=-Wl,-rpath,@executable_path/../../../../liblbug", "-C", "link-arg=-Wl,-rpath,@executable_path/../../../icebug/lib", "-C", "link-arg=-Wl,-rpath,@executable_path/../../../../icebug/lib", + "-C", "link-arg=-Wl,-rpath,/opt/homebrew/lib", + "-C", "link-arg=-Wl,-rpath,/opt/homebrew/opt/apache-arrow/lib", + "-C", "link-arg=-Wl,-rpath,/opt/homebrew/opt/libomp/lib", + "-C", "link-arg=-Wl,-rpath,/usr/local/lib", + "-C", "link-arg=-Wl,-rpath,/usr/local/opt/apache-arrow/lib", + "-C", "link-arg=-Wl,-rpath,/usr/local/opt/libomp/lib", ] [target.aarch64-unknown-linux-gnu] From 2eafb4a5029e141e1f045a9bf17f2c0021b56e6e Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:30:10 -0700 Subject: [PATCH 5/9] Re-enable GDS extension tests in CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit lbug 0.22.0 is out with a compatible algo extension build, and Linux CI now pairs it with the icebug 13.5 prebuilt + Arrow 26. If the served extension breaks ABI again, these tests segfault the harness instead of failing gracefully — re-add targeted --skip flags then. --- .github/workflows/build.yml | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 829fbd7..fa71d00 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -95,14 +95,7 @@ jobs: run: cargo clippy --all-targets -- -D warnings - name: Run tests - run: | - # The algo extension served by INSTALL algo is currently ABI- - # incompatible with pinned lbug 0.21.2: its GDS calls segfault - # inside native code (signal 11, no graceful error), killing the - # whole test harness. Skip those tests until upstream publishes - # compatible bits; re-enable by dropping the --skip flags. - # local_leiden_two_cliques (in-process icebug) still runs. - cargo test -- --skip gds_leiden_two_cliques --skip gds_page_rank_star --skip gds_page_rank_stale_projection_serves_live_storage + run: cargo test build: needs: lint @@ -299,9 +292,6 @@ jobs: # The test INSTALLs the algo extension from the official repo and # LOADs it at runtime: its libarrow dep resolves via our rpaths # (vendored above) on Unix, via PATH (vcpkg) on Windows. - # NOTE: the currently served algo builds segfault inside native - # code against pinned lbug 0.21.2 (see lint job) — same skip here - # until upstream publishes compatible bits. if [ "$RUNNER_OS" = "Windows" ]; then # NB: networkit_state.dll lives in the icebug/lib/networkit # subdir (the win prebuilt splits GlobalState out of the static @@ -314,7 +304,7 @@ jobs: fi # --lib --test selects only these targets so the GUI binary # itself is not linked here (it gets built in the next step). - cargo test --release --target ${{ matrix.target }} --lib --test gds_page_rank -- --skip gds_page_rank_star --skip gds_page_rank_stale_projection_serves_live_storage + cargo test --release --target ${{ matrix.target }} --lib --test gds_page_rank - name: Build release binary run: cargo build --release --target ${{ matrix.target }} From a3936df01588aec50dbfa38b2ba341646d4b65b0 Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:39:35 -0700 Subject: [PATCH 6/9] Pin icebug prebuilt 13.5 on all platforms MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The served 0.22.0 algo extension needs NetworKit symbols added after 13.2 (verified: the Linux and macOS 13.5 prebuilts export them, 13.2 and 13.4 do not). The macOS/Windows 13.5 builds still link libarrow.2500, so the Arrow 25 setup there is unchanged; only the Linux 13.5 build links libarrow.so.2600 (an upstream release-pipeline mistake — hence the Arrow 26 apt pin in CI). --- scripts/download_icebug.sh | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/scripts/download_icebug.sh b/scripts/download_icebug.sh index 2256a56..6ab1977 100755 --- a/scripts/download_icebug.sh +++ b/scripts/download_icebug.sh @@ -16,15 +16,12 @@ TARGET_DIR="${ICEBUG_TARGET_DIR:-$PROJECT_DIR/icebug}" OS="$(uname -s)" ARCH="$(uname -m)" -# Linux CI pairs the 0.22.0 algo extension with NetworKit 13.5 (its -# prebuilt links libarrow.so.2600, hence the Arrow 26 apt pin in CI); -# macOS/Windows stay on 13.4 with the Arrow 25 setup. Overridable per -# run via ICEBUG_VERSION. -case "$OS" in - Linux) DEFAULT_VERSION="13.5" ;; - *) DEFAULT_VERSION="13.4" ;; -esac -VERSION="${ICEBUG_VERSION:-$DEFAULT_VERSION}" +# 13.5 pairs with the served 0.22.0 algo extension (its GDS entry points +# need NetworKit symbols added after 13.2). The macOS/Windows 13.5 builds +# link libarrow.2500, so the Arrow 25 setup there is unchanged; the Linux +# 13.5 build links libarrow.so.2600 (a release-pipeline mistake upstream, +# hence the Arrow 26 apt pin in CI). Overridable per run via ICEBUG_VERSION. +VERSION="${ICEBUG_VERSION:-13.5}" case "$OS" in Darwin) From 912eeda1ff8eb920998ec6420fbf6f439041454d Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:39:40 -0700 Subject: [PATCH 7/9] CI GDS gate: run on Linux, skip macOS/Windows Only the Linux pairing (icebug 13.5 + apt Arrow 26) satisfies the served 0.22.0 extension's loader deps; macOS/Windows keep the Arrow-25-era stack, where the extension can't LOAD (clean failure, but it would still fail the gate). Linux runs the tests for real. --- .github/workflows/build.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index fa71d00..2c8069c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -304,7 +304,15 @@ jobs: fi # --lib --test selects only these targets so the GUI binary # itself is not linked here (it gets built in the next step). - cargo test --release --target ${{ matrix.target }} --lib --test gds_page_rank + # The served 0.22.0 extension needs NetworKit symbols + Arrow 26: + # satisfiable on Linux (icebug 13.5 prebuilt + apt libarrow2600). + # macOS/Windows stay on the Arrow 25-era stack, where the extension + # can't LOAD (clean failure, but it fails the gate all the same), + # so those platforms skip the extension tests. + SKIP_ARGS="--skip gds_page_rank_star --skip gds_page_rank_stale_projection_serves_live_storage" + if [ "$RUNNER_OS" = "Linux" ]; then SKIP_ARGS=""; fi + # shellcheck disable=SC2086 + cargo test --release --target ${{ matrix.target }} --lib --test gds_page_rank $SKIP_ARGS - name: Build release binary run: cargo build --release --target ${{ matrix.target }} From 5b77261f217582c4072d38e019c11ba2914e4deb Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 09:49:36 -0700 Subject: [PATCH 8/9] Fix GDS gate skip passthrough (missing -- separator) --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2c8069c..b4a4e8e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -312,7 +312,7 @@ jobs: SKIP_ARGS="--skip gds_page_rank_star --skip gds_page_rank_stale_projection_serves_live_storage" if [ "$RUNNER_OS" = "Linux" ]; then SKIP_ARGS=""; fi # shellcheck disable=SC2086 - cargo test --release --target ${{ matrix.target }} --lib --test gds_page_rank $SKIP_ARGS + cargo test --release --target ${{ matrix.target }} --lib --test gds_page_rank -- $SKIP_ARGS - name: Build release binary run: cargo build --release --target ${{ matrix.target }} From 435d10cd5da47ca0d595e305ae4bf8cfafcfa6f4 Mon Sep 17 00:00:00 2001 From: Arun Sharma Date: Sun, 25 Oct 2026 10:11:21 -0700 Subject: [PATCH 9/9] CI comment: 13.5 everywhere, Arrow 26 Linux-only --- .github/workflows/build.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b4a4e8e..464efed 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -37,7 +37,8 @@ jobs: echo "deb http://apt.llvm.org/jammy llvm-toolchain-jammy-20 main" | sudo tee /etc/apt/sources.list.d/llvm20.list # Apache Arrow repo (icebug's cxx bridge needs arrow headers). # Pinned to 26.0.0 to match the Linux icebug 13.5 prebuilt, which - # links libarrow.so.2600 (macOS stays on Arrow 25 + icebug 13.4). + # links libarrow.so.2600 (macOS/Windows 13.5 builds link + # libarrow.2500, so they stay on the Arrow 25 setup). wget --timeout=60 --tries=3 https://apache.jfrog.io/artifactory/arrow/ubuntu/apache-arrow-apt-source-latest-jammy.deb sudo apt-get install -y ./apache-arrow-apt-source-latest-jammy.deb # Bound mirror stalls: fail fast instead of hanging the run for hours. @@ -154,7 +155,8 @@ jobs: echo "deb http://apt.llvm.org/jammy llvm-toolchain-jammy-20 main" | sudo tee /etc/apt/sources.list.d/llvm20.list # Apache Arrow repo (icebug's cxx bridge needs arrow headers). # Pinned to 26.0.0 to match the Linux icebug 13.5 prebuilt, which - # links libarrow.so.2600 (macOS stays on Arrow 25 + icebug 13.4). + # links libarrow.so.2600 (macOS/Windows 13.5 builds link + # libarrow.2500, so they stay on the Arrow 25 setup). wget --timeout=60 --tries=3 https://apache.jfrog.io/artifactory/arrow/ubuntu/apache-arrow-apt-source-latest-jammy.deb sudo apt-get install -y ./apache-arrow-apt-source-latest-jammy.deb # Bound mirror stalls: fail fast instead of hanging the run for hours.