Repository navigation
Conversation
Stop pinning a copy of every engine default in this binding. SystemConfig fields are now boxed (Long/Boolean) defaulting to null, meaning "use the engine default". The JNI layer starts from lbug_default_system_config() and only applies non-null values. The legacy lbugDatabaseInit native is removed; its callers now pass nulls for fields the overload predates. Unset settings follow engine-side default changes automatically (e.g. LadybugDB/ladybug#1435's enable_multi_writes flip needs no binding change). Explicitly passed values behave exactly as before. BREAKING CHANGE: SystemConfig fields changed from primitives to boxed types; the lbugDatabaseInit native was removed.
This was referenced Oct 27, 2026
adsharma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17 (which simply flipped the default): instead of pinning a copy of every engine default in this binding,
SystemConfigfields are now boxed (Long/Boolean) defaulting tonull= "use the engine default".SystemConfig.java: boxed fields, null defaults.Database.java: no-config constructors pass all nulls (pure engine defaults); the legacy 9-arg overload passes nulls for the fields it predates (maxNumThreads,enableMultiWrites,enableDefaultHashIndex).Native.java: legacylbugDatabaseInitremoved (resolving the collapse TODO); single boxedlbugDatabaseInitExtended.lbug_java.cpp: unboxes with null checks, applies only non-null values ontolbug_default_system_config()(which it already started from).Unset settings follow engine-side default changes automatically (e.g. LadybugDB/ladybug#1435 needs no binding change). Explicitly passed values behave exactly as before.
BREAKING CHANGE:
SystemConfigfields changed from primitives to boxed types; thelbugDatabaseInitnative was removed.