Repository navigation
Conversation
… synchronously Port of reporter proposal for #29. NodeDatabase::Close now releases native connections/query results still holding the Database (DatabaseDependent registry), including wrappers already GC'd but not finalized, so ~Database() checkpoint cannot run later and rotate a new DB's WAL. Database.close() closes tracked connections first (WeakRef+FinalizationRegistry); open results report 'Query result is closed'. Adds regression test using openDatabaseOnSubprocess lock check.
adsharma
force-pushed
the
fix/29-close-invalidates-dependents
branch
from
November 18, 2026 23:23
ae433b6 to
7ce110f
Compare
Homebrew macos-26 images ship openssl@4 alongside openssl@3 and CMake find_package(OpenSSL 3) resolves to 4.x, tripping the OpenSSL 3.x version guard (Ladybug requires OpenSSL 3.x but found 4.0.3). Same fix as LadybugDB/ladybug 57c7e256b for nodejs-workflow.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29.
Port of reporter proposal.
NodeDatabase::Close now releases native connections/query results still holding the Database (DatabaseDependent registry), including wrappers already GC'd but not finalized, so ~Database() checkpoint cannot run later and rotate a new DB's WAL. Database.close() closes tracked connections first (WeakRef+FinalizationRegistry); open results report 'Query result is closed'.
Verified: deterministic repro now prints wal on disk:true + [a,b,c]; new subprocess-lock regression test passes.