Skip to content

fix(nodejs): close() invalidates dependents so native DB is destroyed synchronously - #30

Open
adsharma wants to merge 3 commits into
mainfrom
fix/29-close-invalidates-dependents
Open

adsharma wants to merge 3 commits into
mainfrom
fix/29-close-invalidates-dependents

Conversation

@adsharma

Copy link
Copy Markdown
Contributor

Closes #29.

Port of reporter proposal.

NodeDatabase::Close now releases native connections/query results still holding the Database (DatabaseDependent registry), including wrappers already GC'd but not finalized, so ~Database() checkpoint cannot run later and rotate a new DB's WAL. Database.close() closes tracked connections first (WeakRef+FinalizationRegistry); open results report 'Query result is closed'.

Verified: deterministic repro now prints wal on disk:true + [a,b,c]; new subprocess-lock regression test passes.

… synchronously

Port of reporter proposal for #29.

NodeDatabase::Close now releases native connections/query results
still holding the Database (DatabaseDependent registry), including
wrappers already GC'd but not finalized, so ~Database() checkpoint
cannot run later and rotate a new DB's WAL. Database.close() closes
tracked connections first (WeakRef+FinalizationRegistry); open results
report 'Query result is closed'.

Adds regression test using openDatabaseOnSubprocess lock check.
@adsharma
adsharma force-pushed the fix/29-close-invalidates-dependents branch from ae433b6 to 7ce110f Compare November 18, 2026 23:23
adsharma and others added 2 commits November 18, 2026 15:26
Homebrew macos-26 images ship openssl@4 alongside openssl@3 and CMake
find_package(OpenSSL 3) resolves to 4.x, tripping the OpenSSL 3.x
version guard (Ladybug requires OpenSSL 3.x but found 4.0.3).

Same fix as LadybugDB/ladybug 57c7e256b for nodejs-workflow.yml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Database.close() leaves the native database open while a QueryResult is alive, and its delayed close breaks a new Database on the same path

1 participant