Skip to content

Commit 2826a2f

Browse files
committed
test(database): exercise the new lenient default in checksums test
The engine build CI uses now carries the checksum-mismatch fix, so a checksum-setting mismatch throws even on the lenient default. Drop the temporary explicit throw_on_wal_replay_failure opt-in; the test now covers the new default.
1 parent 4d3bddf commit 2826a2f

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

‎test/test_database.py‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -205,15 +205,10 @@ def test_database_enable_checksums_config(tmp_path: Path) -> None:
205205
conn.execute("call force_checkpoint_on_close=false")
206206
conn.execute("create node table test(id int64 primary key)")
207207

208-
# running again with enable_checksums=False should give an error, as long as
209-
# WAL replay failures are configured to throw (the engine default is to
210-
# silently ignore them, and the binding no longer overrides that default).
208+
# running again with enable_checksums=False should give an error
209+
# (the engine now throws on a checksum-setting mismatch in both modes).
211210
with pytest.raises(RuntimeError) as check:
212-
db = lb.Database(
213-
database_path=database_path,
214-
enable_checksums=False,
215-
throw_on_wal_replay_failure=True,
216-
)
211+
db = lb.Database(database_path=database_path, enable_checksums=False)
217212

218213

219214
def test_database_close_order() -> None:

0 commit comments

Comments
 (0)