Repository navigation
Fix DATE/TIMESTAMP/TIMESTAMP_TZ ref leak in Python binding - #79
Merged
Merged
Conversation
PyDate_FromDate, PyDateTime_FromDateAndTime and PyDateTimeAPI->DateTime_FromDateAndTime each return a new reference. Wrapping them with py::cast<py::object>(PyObject*) treats the pointer as borrowed and adds another reference, leaking one Python object per value returned via get_next/get_all/get_n/rows_as_dict/iteration (including inside LIST/STRUCT/node/rel). Steal the new reference with py::reinterpret_steal instead, propagating the Python error when construction fails. Fixes LadybugDB#78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78.
PyDate_FromDate, PyDateTime_FromDateAndTime and PyDateTimeAPI->DateTime_FromDateAndTime each return a new reference. Wrapping them with
py::cast<py::object>(PyObject*)treats the pointer as borrowed and adds another reference, leaking one Python object per DATE / TIMESTAMP (all precisions) / TIMESTAMP_TZ value returned via get_next / get_all / get_n / rows_as_dict / iteration (including inside LIST / STRUCT / node / rel).This steals the new reference with
py::reinterpret_steal<py::object>instead, propagating the Python error when construction fails.Verified locally against an incremental release build: the issue's repro now reports 0.00 objects left per value for all types and refcount 1 for a singly-held value (was 1.00 leaked per value and refcount 2).