chore(pay-card): add pay-card-wallets tooling config (LIVE-34772) - #21459
Open
philipptpunkt wants to merge 1 commit into
Open
chore(pay-card): add pay-card-wallets tooling config (LIVE-34772)#21459philipptpunkt wants to merge 1 commit into
philipptpunkt wants to merge 1 commit into
Conversation
CODEOWNERS is last-match-wins, and the `**/tsconfig*`, `**/jest.config*`, `**/.oxlintrc.*` and `**/.oxfmtrc.*` rules sit far below the per-package ones. Every new package therefore needs the tooling owners to approve it, whoever owns the code. Splitting the config files out leaves the package's own PR to its team. Nothing reads these yet: without a package.json the directory is not a workspace member, so no target resolves against it.
Contributor
Web Tools Build Status
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Changes are isolated to new, standard tooling configuration files that match established patterns in other features/flow/* packages.
Pull request overview
Adds per-directory tooling configuration for the new features/flow/pay-card-wallets flow, mirroring existing features/flow/pay-* packages. This supports the stated goal of isolating tooling-owned config files so future package PRs don’t require approval from the global tooling CODEOWNERS rules.
Changes:
- Add TypeScript project configs for base, web, native, and test builds (
tsconfig*.json). - Add Jest config delegating to
@support/jest-features-flow. - Add Oxlint/Oxfmt configuration files consistent with other
features/flow/*packages.
File summaries
| File | Description |
|---|---|
| features/flow/pay-card-wallets/tsconfig.json | Base TS config extending repo defaults; references web/native configs. |
| features/flow/pay-card-wallets/tsconfig.web.json | Web TS config with .web module suffix resolution and native exclusions. |
| features/flow/pay-card-wallets/tsconfig.native.json | Native TS config with .native module suffix resolution and web exclusions. |
| features/flow/pay-card-wallets/tsconfig.test.json | Test TS config (noEmit, no composite/declarations) for Jest usage. |
| features/flow/pay-card-wallets/jest.config.js | Flow Jest config via @support/jest-features-flow. |
| features/flow/pay-card-wallets/.oxlintrc.json | Package-local Oxlint ruleset aligned with existing flow packages. |
| features/flow/pay-card-wallets/.oxfmtrc.json | Package-local Oxfmt formatting config aligned with existing flow packages. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 2, 2026
philipptpunkt
marked this pull request as ready for review
September 2, 2026 15:48
Contributor
Rsdoctor Bundle Diff AnalysisFound 7 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (managed by stac-man)
CODEOWNERS is last-match-wins, and the
**/tsconfig*,**/jest.config*,**/.oxlintrc.*and**/.oxfmtrc.*rules sit far below the per-package ones.Every new package therefore needs the tooling owners to approve it, whoever
owns the code. Splitting the config files out leaves the package's own PR to
its team.
Nothing reads these yet: without a package.json the directory is not a
workspace member, so no target resolves against it.