[LWM] ci(optimisation): skip bundler for non macOS jobs - #21469
Draft
lewisd5 wants to merge 3 commits into
Draft
Conversation
live-github-bot
Bot
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
package.json repository URL is invalid (.git1) and should be corrected before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to reduce CI work for Ledger Live Mobile by skipping Bundler installation steps on non-macOS jobs, while keeping the iOS-related Ruby tooling setup on macOS.
Changes:
- Guard
bundle/bundle installexecution behind a macOS (darwin) platform check in the mobile post script. - Update Bundler missing-command messaging to be more explicit when running on macOS.
- Minor repo root config edits (including an unintended
package.jsonrepository URL change).
File summaries
| File | Description |
|---|---|
package.json |
Repository metadata edited (currently introduces an invalid .git1 URL). |
apps/ledger-live-mobile/scripts/post.mjs |
Skip Bundler setup on non-macOS platforms to optimize CI/runtime. |
.npmrc |
Removes a trailing blank line (no functional impact). |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/LedgerHQ/ledger-live.git" | ||
| "url": "https://github.com/LedgerHQ/ledger-live.git1" |
Contributor
Web Tools Build Status
|
Contributor
Rsdoctor Bundle Diff AnalysisFound 7 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Context