Skip to content

Commit 84df1e9

Browse files
authored
Merge pull request #78 from Lemoncode/#34--Accessibility-use-html5-semantic-elements
#34 accessibility use html5 semantic elements
2 parents 0bf7cb4 + 1372391 commit 84df1e9

4 files changed

Lines changed: 42 additions & 35 deletions

File tree

‎front/src/pods/student/student.component.tsx‎

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,22 @@ export const StudentComponent: React.FC<Props> = props => {
1414
const { mainContainer, sessionName, studentBoard, labelTextarea } = classes;
1515

1616
return (
17-
<div className={mainContainer}>
18-
<Typography className={sessionName} variant="body1">
19-
Session name: {room}
20-
</Typography>
21-
<label className={labelTextarea} htmlFor="session">
22-
Content
23-
</label>
24-
<TextareaAutosize
25-
id="session"
26-
rowsMax={40}
27-
rowsMin={40}
28-
className={studentBoard}
29-
value={log}
30-
/>
31-
</div>
17+
<>
18+
<main className={mainContainer}>
19+
<Typography className={sessionName} variant="body1">
20+
Session name: {room}
21+
</Typography>
22+
<label className={labelTextarea} htmlFor="session">
23+
Content
24+
</label>
25+
<TextareaAutosize
26+
id="session"
27+
rowsMax={40}
28+
rowsMin={40}
29+
className={studentBoard}
30+
value={log}
31+
/>
32+
</main>
33+
</>
3234
);
3335
};

‎front/src/pods/trainer/components/new-text.component.tsx‎

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,26 +44,28 @@ export const NewTextComponent: React.FC<Props> = props => {
4444

4545
return (
4646
<div className={newTextContainer}>
47-
<label className={labelTextarea} htmlFor="new-text">
48-
New text
49-
</label>
50-
<TextareaAutosize
51-
rowsMax={10}
52-
rowsMin={10}
53-
className={editTextArea}
54-
onChange={e => handleOnChange(e)}
55-
value={trainerText}
56-
/>
57-
<Button
58-
variant="contained"
59-
color="primary"
60-
className={trainerText ? sendBtn : sendBtnDisabled}
61-
onClick={() => trainerText && handleAppendTrainerTextInternal()}
62-
aria-disabled={!trainerText}
63-
disableRipple={!trainerText}
64-
>
65-
Send
66-
</Button>
47+
<form>
48+
<label className={labelTextarea} htmlFor="new-text">
49+
New text
50+
</label>
51+
<TextareaAutosize
52+
rowsMax={10}
53+
rowsMin={10}
54+
className={editTextArea}
55+
onChange={e => handleOnChange(e)}
56+
value={trainerText}
57+
/>
58+
<Button
59+
variant="contained"
60+
color="primary"
61+
className={trainerText ? sendBtn : sendBtnDisabled}
62+
onClick={() => trainerText && handleAppendTrainerTextInternal()}
63+
aria-disabled={!trainerText}
64+
disableRipple={!trainerText}
65+
>
66+
Send
67+
</Button>
68+
</form>
6769
</div>
6870
);
6971
};

‎front/src/pods/trainer/components/session.component.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ export const SessionComponent: React.FC<Props> = props => {
2222
rowsMin={20}
2323
className={studentBoard}
2424
value={log}
25+
read-only="true"
26+
aria-readonly
2527
/>
2628
</div>
2729
);

‎front/src/pods/trainer/trainer.component.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export const TrainerComponent: React.FC<Props> = props => {
2828
currentTrainerUrl={currentTrainerUrl}
2929
currentStudentUrl={currentStudentUrl}
3030
/>
31+
3132
<NewTextComponent handleAppendTrainerText={handleAppendTrainerText} />
3233
<SessionComponent log={log} />
3334
</main>

0 commit comments

Comments
 (0)