Merge pull request #129 from Lemoncode/fix-upsert-room-content

upsert fix

Author: brauliodiez

back/src/dals/room/repository/room.repository.ts

@@ -1,12 +1,17 @@
-import { RoomInfo, RoomContext } from 'dals'
+import { RoomInfo, RoomContext } from 'dals';
 
 export const isRoomAvailable = async (room: string): Promise<boolean> => {
   const roomAvailable = !(await RoomContext.exists({ room }));
   return roomAvailable;
-}
-  
-export const saveRoomInfo = async (newRoomInfo: RoomInfo, setFullText: boolean): Promise<void> => {
-    await isRoomAvailable(newRoomInfo.room) ? await insertRoom(newRoomInfo) : await updateRoomContent(newRoomInfo, setFullText);
+};
+
+export const saveRoomInfo = async (
+  newRoomInfo: RoomInfo,
+  setFullText: boolean
+): Promise<void> => {
+  (await isRoomAvailable(newRoomInfo.room))
+    ? await insertRoom(newRoomInfo)
+    : await updateRoomContent(newRoomInfo, setFullText);
 };
 
 export const getRoomContent = async (room: string): Promise<string> => {
@@ -15,19 +20,35 @@ export const getRoomContent = async (room: string): Promise<string> => {
 };
 
 const getRoomByName = async (room: string): Promise<RoomInfo> => {
-  return (await RoomContext.findOne({room: room}).lean());
+  return await RoomContext.findOne({ room: room }).lean();
 };
 
-const updateRoomContent = async (newRoomInfo: RoomInfo, setFullText:boolean): Promise<void> => {
+const appendRoomContent = async (newRoomInfo: RoomInfo): Promise<void> => {
   const room: RoomInfo = await getRoomByName(newRoomInfo.room);
-  let newContent = "";
-  if(room && Boolean(room.content) && !setFullText) {
-    newContent = room.content + '\n';
+
+  if (room) {
+    const newContent = `${room.content}\n${newRoomInfo.content}`;
+    await RoomContext.updateOne(
+      { room: newRoomInfo.room },
+      { content: newContent }
+    );
   }
-  newContent = setFullText ? newRoomInfo.content : (newContent + newRoomInfo.content);
-  await RoomContext.updateOne({room: newRoomInfo.room}, {content: newContent});
 };
-  
+
+const replaceRoomContent = async (newRoomInfo: RoomInfo): Promise<void> =>
+  await RoomContext.updateOne(
+    { room: newRoomInfo.room },
+    { content: newRoomInfo.content }
+  );
+
+const updateRoomContent = async (
+  newRoomInfo: RoomInfo,
+  setFullText: boolean
+): Promise<void> =>
+  setFullText
+    ? replaceRoomContent(newRoomInfo)
+    : appendRoomContent(newRoomInfo);
+
 const insertRoom = async (newRoomInfo: RoomInfo): Promise<void> => {
   await RoomContext.create(newRoomInfo);
 };