Repository navigation
Commit 16586ec
committed
a docs commit rebuilt and re-signed a binary that had not changed
Publishing a rolling build on every push to main meant a README edit
produced a new signed artifact identical to the last one. That is not
just waste: a release appearing says something shipped, and nothing had.
The obvious fix is a paths-ignore on the push trigger, and it is wrong.
A path filter under `on.push` cannot be scoped to branches, so it would
sit in front of the tag trigger too, and a tag usually points at a commit
that was already pushed. Whether GitHub considers such a push to have
changed any files is not something worth learning by cutting a release
and watching nothing happen.
So the two triggers stop sharing an event. release.yml keeps the tag
trigger and gains workflow_call; rolling.yml owns main, carries the path
filter, and calls release.yml. One job body, no duplication, and the
github context in a called workflow belongs to the caller, so the
branch-vs-tag branch inside it still sees exactly what it saw before.
Nothing under an ignored path can reach the binary. The assets that do
are compiled in from assets/, which is not ignored, and ci.yml has no
path filter at all, so the tests that read README.md still run on every
push regardless of what this skips.
actionlint covers the new failure mode too, verified by sabotage:
removing workflow_call from release.yml makes it report that rolling.yml
calls a workflow that cannot be called. 133 tests, 3 workflows clean.1 parent 5870746 commit 16586ec
2 files changed
Lines changed: 33 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
0 commit comments