Skip to content

Commit 8c544a3

Browse files
committed
smoke: the Koguma laps meet the shellcheck gate
The test job's fmt step had been failing first since the emoji push, so shellcheck never ran against the Koguma and hardening laps 225f40f and 71fff6f added: this is the first run that reached the step, and it found two of its own. The activation-socket wait quotes $(id -u) single so the GUEST's uid answers the probe; the directive names that, beside the house's other guest-expansion ones. The hardening lap declared a got it never read. Both verified against the pinned v0.11.0 image locally, per the step's own comment.
1 parent ba9269f commit 8c544a3

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎scripts/smoke.sh‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1553,6 +1553,7 @@ smoke_published() {
15531553
guest 'systemd-run --user --unit=kuma-files-smoke kuma-files' \
15541554
|| bad "kuma-files would not launch from the session's user manager"
15551555
local koguma_deadline=$((SECONDS + 60))
1556+
# shellcheck disable=SC2016 # $(id -u) must expand on the guest, not here
15561557
until guest 'pgrep -x kuma-files >/dev/null && test -S "/run/user/$(id -u)/kuma-files.sock"'; do
15571558
[ $SECONDS -lt $koguma_deadline ] \
15581559
|| bad "kuma-files launched but never answered: no process or no activation socket"
@@ -3294,7 +3295,7 @@ smoke_boot() {
32943295
# lets it, so green on the lane asserts the rule as much as the
32953296
# harness. A sysctl that drifts means either the file stopped
32963297
# shipping or a base change stopped it applying, and both are news.
3297-
local hard got want
3298+
local hard want
32983299
hard=$(guest 'sysctl -n kernel.yama.ptrace_scope kernel.kptr_restrict \
32993300
kernel.perf_event_paranoid kernel.kexec_load_disabled fs.suid_dumpable \
33003301
vm.unprivileged_userfaultfd vm.mmap_rnd_bits net.core.bpf_jit_harden \

0 commit comments

Comments
 (0)