Skip to content

fix: replace deprecated OTA password with encryption #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lewa-Reka merged 1 commit into from
Oct 10, 2026
Merged

fix: replace deprecated OTA password with encryption #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xHP3.factory.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ota:
- platform: http_request
id: ota_http_request
- id: !extend ota_esphome
password: !remove
encryption: !remove

improv_serial:

Expand Down
3 changes: 1 addition & 2 deletions devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xHP3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

substitutions:
api_key: ""
ota_password: ""
fallback_password: ""
wifi_ssid: ""
wifi_password: ""
Expand All @@ -40,7 +39,7 @@ packages:
esphome:
name: deye-inverter
friendly_name: Deye Inverter
min_version: "2026.8.0"
min_version: "2026.9.0"
name_add_mac_suffix: true

uart:
Expand Down
2 changes: 1 addition & 1 deletion devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP1.factory.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ota:
- platform: http_request
id: ota_http_request
- id: !extend ota_esphome
password: !remove
encryption: !remove

improv_serial:

Expand Down
3 changes: 1 addition & 2 deletions devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

substitutions:
api_key: ""
ota_password: ""
fallback_password: ""
wifi_ssid: ""
wifi_password: ""
Expand All @@ -37,7 +36,7 @@ packages:
esphome:
name: deye-inverter
friendly_name: Deye Inverter
min_version: "2026.8.0"
min_version: "2026.9.0"
name_add_mac_suffix: true

uart:
Expand Down
2 changes: 1 addition & 1 deletion devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP3.factory.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ota:
- platform: http_request
id: ota_http_request
- id: !extend ota_esphome
password: !remove
encryption: !remove

improv_serial:

Expand Down
3 changes: 1 addition & 2 deletions devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

substitutions:
api_key: ""
ota_password: ""
fallback_password: ""
wifi_ssid: ""
wifi_password: ""
Expand All @@ -40,7 +39,7 @@ packages:
esphome:
name: deye-inverter
friendly_name: Deye Inverter
min_version: "2026.8.0"
min_version: "2026.9.0"
name_add_mac_suffix: true

uart:
Expand Down
2 changes: 0 additions & 2 deletions docs/INSTALLATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ This is the easiest way to get started if you're using Home Assistant.
wifi_ssid: "YourWiFiSSID"
wifi_password: "YourWiFiPassword"
pv_inverter_api_key: "your-32-character-api-key"
pv_inverter_ota_password: "your-ota-password"
pv_inverter_fallback_password: "your-fallback-password"
```
2. Click **"EDIT"** on your newly created device
Expand Down Expand Up @@ -92,7 +91,6 @@ If you prefer using command line or don't have Home Assistant:
wifi_ssid: "YourWiFiSSID"
wifi_password: "YourWiFiPassword"
pv_inverter_api_key: "your-32-character-api-key"
pv_inverter_ota_password: "your-ota-password"
pv_inverter_fallback_password: "your-fallback-password"
```

Expand Down
1 change: 0 additions & 1 deletion pv-inverter.Deye-SG0XHP3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
1 change: 0 additions & 1 deletion pv-inverter.Deye-SG0XLP1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
1 change: 0 additions & 1 deletion pv-inverter.Deye-SG0XLP3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
1 change: 0 additions & 1 deletion pv-inverter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
4 changes: 2 additions & 2 deletions pv_inverter/packages/init.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ esphome:
name: "${name}"
friendly_name: "${friendly_name}"
comment: "${device_description} by Lewa-Reka https://github.com/Lewa-Reka/esphome-deye-inverter"
min_version: "2026.8.0"
min_version: "2026.9.0"

@sourcery-ai sourcery-ai Bot Oct 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · ESPHome 2026.8 rejects configuration

When a user follows the documented minimum and runs ESPHome 2026.8, the min_version check rejects the configuration, so users cannot validate, build, or install it and see a version error.

Align min_version with the documented 2026.8 minimum, or update the documentation to require 2026.9.

Also at devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xHP3.yaml:42, devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP1.yaml:39, devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP3.yaml:42.

Prompt for AI agents 
In `pv_inverter/packages/init.yaml` at line 22:

**ESPHome 2026.8 rejects configuration**

When a user follows the documented minimum and runs ESPHome 2026.8, the `min_version` check rejects the configuration, so users cannot validate, build, or install it and see a version error.

Align `min_version` with the documented 2026.8 minimum, or update the documentation to require 2026.9.

Also at `devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xHP3.yaml:42`, `devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP1.yaml:39`, `devices/Waveshare-ESP32-S3-RS485-CAN/Deye-SG0xLP3.yaml:42`.

project:
name: "lewa-reka.deye-inverter"
version: "0.15.0-rc"
Expand Down Expand Up @@ -48,7 +48,7 @@ api:
ota:
- platform: esphome
id: ota_esphome
password: ${ota_password}
encryption: # reuses the api encryption key

wifi:
ssid: ${wifi_ssid}
Expand Down
1 change: 0 additions & 1 deletion tests/deye_hybrid_1p_lv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
1 change: 0 additions & 1 deletion tests/deye_hybrid_3p_hv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
1 change: 0 additions & 1 deletion tests/deye_hybrid_3p_lv.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ substitutions:
wifi_ssid: !secret wifi_ssid
wifi_password: !secret wifi_password
api_key: !secret pv_inverter_api_key
ota_password: !secret pv_inverter_ota_password
fallback_password: !secret pv_inverter_fallback_password

modbus_inverter_address: "0x01" # Default Modbus address, should be changed to match inverter settings
Expand Down
1 change: 0 additions & 1 deletion tests/secrets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
wifi_ssid: "test_ssid"
wifi_password: "test_Password_123"
pv_inverter_api_key: "n3F5I1v1gJ5J9p2vL8bV6d8nQ1r2kU4p/sW3zC9xG7o="
pv_inverter_ota_password: "test_Password_123"
pv_inverter_fallback_password: "test_Password_123"
Loading