cs_CZ thesaurus converter: guard missing type column - #58
Closed
ashishkrshaw wants to merge 1 commit into
Closed
Conversation
|
Thank you for your contribution. We use GitHub as a read-only mirror, so please submit your patch into our own code review system: https://wiki.documentfoundation.org/Development/GetInvolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cs_CZ/thesaurus/dictionary-to-thesaurus.py, parse() checks len(terms) >= 2 and then reads terms[2]. For input rows with only two tab-separated columns, this can raise IndexError and stop conversion.\n\nThis patch changes the guard to len(terms) >= 3 before reading terms[2], keeping typ empty when the optional third column is missing. The converter now handles two-column rows safely.