Skip to content

Fix the PPO example docstrings to name the arguments the constructors take #21887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darkdi wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

Fix the PPO example docstrings to name the arguments the constructors take #21887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions examples/pytorch/domain_templates/reinforce_learn_ppo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ class ActorCategorical(nn.Module):
def __init__(self, actor_net):
"""
Args:
input_shape: observation shape of the environment
n_actions: number of discrete actions available in the environment
actor_net: network that maps an observation to action logits
"""
super().__init__()

Expand Down Expand Up @@ -95,8 +94,8 @@ class ActorContinuous(nn.Module):
def __init__(self, actor_net, act_dim):
"""
Args:
input_shape: observation shape of the environment
n_actions: number of discrete actions available in the environment
actor_net: network that maps an observation to the mean of the action distribution
act_dim: number of continuous action dimensions
"""
super().__init__()
self.actor_net = actor_net
Expand Down