Skip to content

Commit 1256a60

Browse files
committed
ci: run web-ext with npm
To run web-ext, runs the following commands: - lint: `npm run lint:webext` - build: `npm run build`.
1 parent 611b28a commit 1256a60

5 files changed

Lines changed: 3837 additions & 367 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@ jobs:
2121

2222
- name: Setup Node.js
2323
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
24-
- name: Install web-ext
25-
run: npm install --global web-ext
24+
- name: Install the dependencies
25+
run: npm ci
2626
- name: Display web-ext version
27-
run: web-ext --version
27+
run: npx web-ext --version
2828

2929
- name: Build with web-ext
30-
run: web-ext build
30+
run: npm run build
3131

3232
- name: Upload Firefox artifact
3333
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1

‎.github/workflows/lint.yml‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,21 @@ jobs:
1515

1616
- name: Setup Node.js
1717
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
18-
19-
# eslint
2018
- name: Install the dependencies
2119
run: npm ci
20+
21+
# eslint
2222
- name: Lint the scripts
2323
run: npm run lint
2424

2525
# web-ext
26-
- name: Install web-ext
27-
run: npm install --global web-ext
2826
- name: Display web-ext version
29-
run: web-ext --version
27+
run: npx web-ext --version
3028
# Firefox ignores Chrome's "service_worker" key and web-ext lint warns
3129
# about it: BACKGROUND_SERVICE_WORKER_IGNORED. Strip it before linting
3230
- name: Drop Chrome-only service_worker key for Firefox lint
3331
run: |
3432
jq 'del(.background.service_worker)' manifest.json > manifest.tmp
3533
mv manifest.tmp manifest.json
3634
- name: Lint the webextension
37-
run: web-ext lint --warnings-as-errors
35+
run: npm run lint:webext -- --warnings-as-errors

‎DOCUMENTATION.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ On open, the popup:
8787
│ ├── icon-*.png # toolbar / store icons
8888
│ └── icon.svg # source icon
8989
├── tests/ # test suite (node --test), one file per module
90-
├── package.json # npm scripts + dev dependencies (ESLint)
90+
├── package.json # npm scripts + dev dependencies (ESLint, web-ext)
9191
├── eslint.config.js # ESLint flat config
9292
├── .web-ext-config.mjs # web-ext config: files to keep out of the package
9393
└── .github/ # CI workflows (lint, test, build) + dependabot

0 commit comments

Comments
 (0)