Skip to content

Commit 30b6d50

Browse files
authored
fix(compat): set last_updated when storing a task in v0.3 format (a2aproject#1372)
## Problem `core_to_compat_task_model` left `last_updated` unset, so in zero-downtime migration mode `ListTasks` with `status_timestamp_after` returned nothing. ## Fix Set it from `status.timestamp`, as the v1.0 path in `DatabaseTaskStore` does. ## Tests `test_task_db_conversion_sets_last_updated` fails on main. 2305 passed. Fixes a2aproject#1371
1 parent 261c074 commit 30b6d50

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

‎src/a2a/compat/v0_3/model_conversions.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ def core_to_compat_task_model(task: pb2_v10.Task, owner: str) -> TaskModel:
3232
artifacts=data.get('artifacts'),
3333
task_metadata=data.get('metadata'),
3434
protocol_version='0.3',
35+
last_updated=(
36+
task.status.timestamp.ToDatetime()
37+
if task.status.HasField('timestamp')
38+
else None
39+
),
3540
)
3641

3742

‎tests/compat/v0_3/test_conversions.py‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import base64
22
import json
33

4+
from datetime import datetime
5+
46
import pytest
57

68
from a2a.compat.v0_3 import types as types_v03
@@ -1963,6 +1965,18 @@ def test_task_db_conversion():
19631965
assert v10_restored.metadata == v10_task.metadata
19641966

19651967

1968+
def test_task_db_conversion_sets_last_updated():
1969+
"""The status timestamp becomes last_updated, as in the v1.0 model."""
1970+
v10_task = pb2_v10.Task(id='task-123', context_id='ctx-456')
1971+
v10_task.status.timestamp.FromJsonString('2026-10-01T12:00:00Z')
1972+
1973+
model = core_to_compat_task_model(v10_task, 'owner-789')
1974+
assert model.last_updated == datetime(2026, 10, 1, 12, 0)
1975+
1976+
v10_task.status.ClearField('timestamp')
1977+
assert core_to_compat_task_model(v10_task, 'owner-789').last_updated is None
1978+
1979+
19661980
def test_push_notification_config_db_conversion():
19671981
task_id = 'task-123'
19681982
v10_config = pb2_v10.TaskPushNotificationConfig(

0 commit comments

Comments
 (0)