Skip to content

Commit 4e01a91

Browse files
authored
fix(errors): align error mappings with A2A spec (a2aproject#1055)
# Description Aligns A2A error mappings with the canonical mapping in [A2A spec](https://a2a-protocol.org/latest/specification/#54-error-code-mappings). # Changes - `grpc_handler.py` _ERROR_CODE_MAP: PushNotificationNotSupportedError, UnsupportedOperationError, VersionNotSupportedError → FAILED_PRECONDITION (was UNIMPLEMENTED). - `errors.py` A2A_REST_ERROR_MAPPING: same three errors' gRPC status updated to FAILED_PRECONDITION; TaskNotCancelableError HTTP 409 → 400; InvalidAgentResponseError HTTP 502 → 500. - `test_grpc_handler.py`: updated parametrized expectations for the two affected gRPC test cases. Issue a2aproject#1027 🦕
1 parent 94ad594 commit 4e01a91

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

‎src/a2a/server/request_handlers/grpc_handler.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ def _get_metadata_value(
8989
types.InternalError: grpc.StatusCode.INTERNAL,
9090
types.TaskNotFoundError: grpc.StatusCode.NOT_FOUND,
9191
types.TaskNotCancelableError: grpc.StatusCode.FAILED_PRECONDITION,
92-
types.PushNotificationNotSupportedError: grpc.StatusCode.UNIMPLEMENTED,
93-
types.UnsupportedOperationError: grpc.StatusCode.UNIMPLEMENTED,
92+
types.PushNotificationNotSupportedError: grpc.StatusCode.FAILED_PRECONDITION,
93+
types.UnsupportedOperationError: grpc.StatusCode.FAILED_PRECONDITION,
9494
types.ContentTypeNotSupportedError: grpc.StatusCode.INVALID_ARGUMENT,
9595
types.InvalidAgentResponseError: grpc.StatusCode.INTERNAL,
9696
types.ExtendedAgentCardNotConfiguredError: grpc.StatusCode.FAILED_PRECONDITION,
9797
types.ExtensionSupportRequiredError: grpc.StatusCode.FAILED_PRECONDITION,
98-
types.VersionNotSupportedError: grpc.StatusCode.UNIMPLEMENTED,
98+
types.VersionNotSupportedError: grpc.StatusCode.FAILED_PRECONDITION,
9999
}
100100

101101

‎src/a2a/utils/errors.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,23 +149,23 @@ class VersionNotSupportedError(A2AError):
149149
A2A_REST_ERROR_MAPPING: dict[type[A2AError], RestErrorMap] = {
150150
TaskNotFoundError: RestErrorMap(404, 'NOT_FOUND', 'TASK_NOT_FOUND'),
151151
TaskNotCancelableError: RestErrorMap(
152-
409, 'FAILED_PRECONDITION', 'TASK_NOT_CANCELABLE'
152+
400, 'FAILED_PRECONDITION', 'TASK_NOT_CANCELABLE'
153153
),
154154
PushNotificationNotSupportedError: RestErrorMap(
155155
400,
156-
'UNIMPLEMENTED',
156+
'FAILED_PRECONDITION',
157157
'PUSH_NOTIFICATION_NOT_SUPPORTED',
158158
),
159159
UnsupportedOperationError: RestErrorMap(
160-
400, 'UNIMPLEMENTED', 'UNSUPPORTED_OPERATION'
160+
400, 'FAILED_PRECONDITION', 'UNSUPPORTED_OPERATION'
161161
),
162162
ContentTypeNotSupportedError: RestErrorMap(
163-
415,
163+
400,
164164
'INVALID_ARGUMENT',
165165
'CONTENT_TYPE_NOT_SUPPORTED',
166166
),
167167
InvalidAgentResponseError: RestErrorMap(
168-
502, 'INTERNAL', 'INVALID_AGENT_RESPONSE'
168+
500, 'INTERNAL', 'INVALID_AGENT_RESPONSE'
169169
),
170170
ExtendedAgentCardNotConfiguredError: RestErrorMap(
171171
400,
@@ -178,7 +178,7 @@ class VersionNotSupportedError(A2AError):
178178
'EXTENSION_SUPPORT_REQUIRED',
179179
),
180180
VersionNotSupportedError: RestErrorMap(
181-
400, 'UNIMPLEMENTED', 'VERSION_NOT_SUPPORTED'
181+
400, 'FAILED_PRECONDITION', 'VERSION_NOT_SUPPORTED'
182182
),
183183
InvalidParamsError: RestErrorMap(400, 'INVALID_ARGUMENT', 'INVALID_PARAMS'),
184184
InvalidRequestError: RestErrorMap(

‎tests/server/request_handlers/test_grpc_handler.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,12 +334,12 @@ async def test_list_tasks_success(
334334
),
335335
(
336336
types.PushNotificationNotSupportedError(),
337-
grpc.StatusCode.UNIMPLEMENTED,
337+
grpc.StatusCode.FAILED_PRECONDITION,
338338
'PushNotificationNotSupportedError',
339339
),
340340
(
341341
types.UnsupportedOperationError(),
342-
grpc.StatusCode.UNIMPLEMENTED,
342+
grpc.StatusCode.FAILED_PRECONDITION,
343343
'UnsupportedOperationError',
344344
),
345345
(

0 commit comments

Comments
 (0)