Repository navigation
Commit ad85806
fix(server): record executor failures through the event consumer (a2aproject#1366)
# Description
When an executor enqueues its `Task` and raises before that Task is
saved, `_run_producer` and the consumer both insert the same row through
the shared `TaskManager`. With `DatabaseTaskStore` one insert fails, and
the request either returns the `SUBMITTED` task as a success or raises
`IntegrityError` instead of the executor's error.
This moves the failure write to `EventConsumer`, as suggested on the
issue:
- `_run_producer` no longer saves the failure. It only enqueues the
exception, as before.
- The consumer records the failure when it dequeues the exception, so
FAILED is written after every event the executor enqueued before
raising.
- `_write_failed_status` creates the fallback task through
`ensure_task_id`, with the context id from `_task_manager.context_id`,
only when no task exists, which keeps the case a2aproject#1106 fixed. FAILED is
stamped with the failure time, so `last_updated` is set. The write goes
through `_handle_task_modification_event` rather than
`_handle_task_event`, so it still lands when the agent answered with a
Message.
Visible differences from the old producer write:
- FAILED carries the time of the failure. The old write kept the
previous status time, or none, which left `last_updated` NULL.
- The agent's last status message moves from `status.message` into
`history`, as on any status update.
- When a resumed task fails, the follow-up user message is now recorded
in `history`. The old write dropped it.
Three tests are added. One holds the store's insert of the agent's Task
until the executor has raised, which is the window a database round trip
leaves open. It fails on `main` with `UNIQUE constraint failed:
tasks.id` and passes with this change. The other two check that a task
which fails after reporting progress is stamped with the failure time,
and that a follow-up answered with a Message still leaves the task
FAILED.
Checks on current `main` (79a6f45), Python 3.10: the full suite passes
with Postgres 18 behind the database tests (2396 passed, 92 skipped; the
4 cross-version tests timed out starting their servers in that run and
pass on their own). I did not run the MySQL tests. `ruff check`, `ruff
format --check` and `ty check` show nothing new.
- [x] Follow the [`CONTRIBUTING`
Guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)
Fixes a2aproject#1351
---------
Co-authored-by: Mateusz Iwaniuk <45974414+Iwaniukooo11@users.noreply.github.com>1 parent 30b6d50 commit ad85806
3 files changed
Lines changed: 234 additions & 19 deletions
File tree
- src/a2a/server/agent_execution
- tests/server
- agent_execution
- request_handlers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
118 | 122 | | |
119 | 123 | | |
120 | 124 | | |
| |||
160 | 164 | | |
161 | 165 | | |
162 | 166 | | |
163 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
164 | 190 | | |
165 | 191 | | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
166 | 196 | | |
167 | 197 | | |
168 | 198 | | |
169 | | - | |
| 199 | + | |
170 | 200 | | |
171 | 201 | | |
172 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
173 | 206 | | |
174 | 207 | | |
175 | 208 | | |
| |||
219 | 252 | | |
220 | 253 | | |
221 | 254 | | |
| 255 | + | |
| 256 | + | |
222 | 257 | | |
223 | 258 | | |
224 | 259 | | |
| |||
599 | 634 | | |
600 | 635 | | |
601 | 636 | | |
602 | | - | |
603 | 637 | | |
604 | 638 | | |
605 | 639 | | |
| |||
667 | 701 | | |
668 | 702 | | |
669 | 703 | | |
670 | | - | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
678 | | - | |
679 | | - | |
680 | | - | |
| 704 | + | |
| 705 | + | |
681 | 706 | | |
682 | 707 | | |
683 | 708 | | |
| |||
907 | 932 | | |
908 | 933 | | |
909 | 934 | | |
910 | | - | |
911 | | - | |
912 | | - | |
913 | | - | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
914 | 938 | | |
915 | 939 | | |
916 | 940 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
390 | 391 | | |
391 | 392 | | |
392 | 393 | | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
393 | 457 | | |
394 | 458 | | |
395 | 459 | | |
| |||
1599 | 1663 | | |
1600 | 1664 | | |
1601 | 1665 | | |
| 1666 | + | |
| 1667 | + | |
| 1668 | + | |
| 1669 | + | |
| 1670 | + | |
| 1671 | + | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
| 1777 | + | |
| 1778 | + | |
| 1779 | + | |
| 1780 | + | |
| 1781 | + | |
| 1782 | + | |
| 1783 | + | |
| 1784 | + | |
| 1785 | + | |
| 1786 | + | |
| 1787 | + | |
| 1788 | + | |
| 1789 | + | |
| 1790 | + | |
| 1791 | + | |
1602 | 1792 | | |
1603 | 1793 | | |
1604 | 1794 | | |
| |||
0 commit comments