You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit d316d0e
Browse filesBrowse the repository at this point in the historyBrowse files
fix(client): Create separate httpx per client when none configured (a2aproject#1358)
Closesa2aproject#1349
## Issue
if `httpx` object was not provided in `ClientConfig` when creating
`ClientFactory()`, the default one was created and was shared **across
clients**
## Fix
If `httpx` object is not provided, the default one is created when
**creating new client**. Thus, closing connection on one client doesen't
affect the other clients
## Note
If `httpx` is provided, all client created by factory keep the reference
and it is expected behaviour
## Tests
Added one tests which check if:
- Clients from the same `ClientFacotry` have different httpx objects
(providing config was empty)
- Closing connection twice throws `A2AClientError`
- Closing can't be done from sdk-scope (only http author can close its
connection)
0 commit comments