Repository navigation
components: Fix bit-sel inputs of generic mux/demux when not a power of two - #4739
Merged
Merged
Conversation
grandixximo
reviewed
Oct 30, 2026
BsAtHome
force-pushed
the
fix_mux-demux-power-of-two
branch
from
October 30, 2026 10:00
f15cb3a to
94d4d92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
mux_genericanddemux_genericdid not create bit-select pins of multiplex inputs or demultiplex outputs if the number was not a power of two. This PR fixes that issue and always creates enoughsel-bit-##pins to select any of the inputs/outputs generated.Additionally, it fixes a missing test after HAL memory allocation and ensures no signed/unsigned confusion when the select input is combined with the bit select inputs and comparison with the size.
Fixes #4731.