Repository navigation
Conversation
| and2(9) | ||
| and | ||
| or2(9). | ||
| or(9), and2(9) and or2(9). |
There was a problem hiding this comment.
Should this be or_n(9) now, after the rename? Same for and(9) in or_n.comp see_also.
| or(9), and2(9) and or2(9). | |
| or_n(9), and2(9) and or2(9). |
| maximum number of inputs is 128 (hardcoded). If there are no input pins at all (personality=0); then | ||
| the output is *FALSE*. | ||
| Set the number of pins via personality. The default value is a single *OR* with 8 | ||
| inputs; so personality=8. The maximum number of inputs is 155(hardcoded). If there |
There was a problem hiding this comment.
I think 155 should be 255, or am I missing something?
| inputs; so personality=8. The maximum number of inputs is 155(hardcoded). If there | |
| inputs; so personality=8. The maximum number of inputs is 255 (hardcoded). If there |
|
|
||
| license "ASLv2"; | ||
| license "GPL"; | ||
| author "Dirk-Willem van Gulik <dirkx(at)webweaving(punto)org"; |
There was a problem hiding this comment.
Missing the closing >? Same in or_n.comp.
| author "Dirk-Willem van Gulik <dirkx(at)webweaving(punto)org"; | |
| author "Dirk-Willem van Gulik <dirkx(at)webweaving(punto)org>"; |
| @@ -1,15 +1,15 @@ | |||
| component or "Arbitrary input OR gate"; | |||
| pin in bool in##[128:personality] = 0 "in"; | |||
| component or_n "compute the logical OR of up to 255 inputs."; | |||
There was a problem hiding this comment.
Small things: "Compute" capitalised like and_n, and maybe a doc string on function _ as in and_n? git diff --check also shows some trailing whitespace in both files.
|
You may need to rebase to master. The original merge was reverted. It seems that this PR is trying to diff something that is not present in current master. Not sure why this isn't flagged. |
|
I think that is just how it looks after a revert, the files may not be present in the current head of master, but they are present in the history. |
Replaces/fixes PR #4720.