Adding warnings and errors for each compiler and fixing code based on those. Removed option DBC_GENERATE_PKGCONFIG

Author: LinuxDevon

CMakeLists.txt

@@ -8,8 +8,6 @@ project(dbc
 # -- PROJECT OPTIONS  -- #
 option(DBC_ENABLE_TESTS "Enable Unittests" ON)
 option(DBC_TEST_LOCALE_INDEPENDENCE "Used to deterime if the libary is locale agnostic when it comes to converting floats. You need `de_DE.UTF-8` locale installed for this testing." OFF)
-# Turn OFF, if you are using FetchContent to include it to your project
-option(DBC_GENERATE_PKGCONFIG "Include project with FetchContent_Declare in another project. In this case the headers and the cmake files are not needed, only the library" OFF)
 option(DBC_GENERATE_DOCS "Use doxygen if installed to generated documentation files" OFF)
 # ---------------------- #
 
@@ -65,36 +63,42 @@ if(DBC_GENERATE_DOCS)
     add_subdirectory(doc)
 endif()
 
+if (MSVC)
+    add_compile_options(/W4 /WX)
+else()
+    add_compile_options(-Wall -Wextra -Wpedantic -Werror)
+endif()
+
 add_library(${PROJECT_NAME} STATIC ${SOURCE_FILES})
 target_link_libraries(${PROJECT_NAME} FastFloat::fast_float)
 target_include_directories(${PROJECT_NAME} PUBLIC
     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
     $<INSTALL_INTERFACE:include>
 )
+target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_11)
 
 target_sources(${PROJECT_NAME} INTERFACE FILE_SET HEADERS
         TYPE HEADERS
         BASE_DIRS ${PROJECT_SOURCE_DIR}/include/libdbc
-        FILES ${HEADER_FILES})
+        FILES ${HEADER_FILES}
+)
 
 add_custom_target(release
 					WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
 					COMMAND ${CMAKE_SOURCE_DIR}/scripts/create_single_header.sh
-					DEPENDS ${PROJECT_NAME})
+					DEPENDS ${PROJECT_NAME}
+)
 
 ## Installation
 # install lib
 install(TARGETS ${PROJECT_NAME}
 		DESTINATION ${CMAKE_INSTALL_LIBDIR})
 
 # install headers
-nstall(DIRECTORY ${PROJECT_SOURCE_DIR}/include/libdbc DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
-
+install(DIRECTORY ${PROJECT_SOURCE_DIR}/include/libdbc DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 
-if (NOT DBC_GENERATE_PKGCONFIG)
-    # Generate pkg-config file
-    configure_file(${PROJECT_NAME}.pc.in ${PROJECT_NAME}.pc @ONLY)
-    install(
-        FILES ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}.pc
-        DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
-endif()
+# Generate pkg-config file
+configure_file(${PROJECT_NAME}.pc.in ${PROJECT_NAME}.pc @ONLY)
+install(
+    FILES ${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}.pc
+    DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)

include/libdbc/message.hpp

@@ -10,6 +10,7 @@
 namespace libdbc {
 struct Message {
 	Message() = delete;
+	virtual ~Message() = default;
 	explicit Message(uint32_t id, const std::string& name, uint8_t size, const std::string& node);
 
 	enum class ParseSignalsStatus {

include/libdbc/signal.hpp

@@ -29,6 +29,7 @@ struct Signal {
 	std::vector<SignalValueDescriptions> svDescriptions;
 
 	Signal() = delete;
+	virtual ~Signal() = default;
 	explicit Signal(std::string name,
 					bool is_multiplexed,
 					uint32_t start_bit,

test/CMakeLists.txt

@@ -10,6 +10,17 @@ FetchContent_Declare(
 FetchContent_MakeAvailable(Catch2)
 include(Catch)
 
+if (MSVC)
+    add_compile_options(/W4 /WX)
+else()
+    add_compile_options(-Wall -Wextra -Wpedantic -Werror)
+endif()
+
+# Code coverage compiler specific
+if (GCC)
+  add_compile_options(--coverage)
+endif()
+
 add_executable(dbcParserTests
     test_dbc.cpp
     test_utils.cpp

test/test_dbc.cpp

@@ -4,6 +4,7 @@
 #include <catch2/catch_test_macros.hpp>
 #include <catch2/matchers/catch_matchers.hpp>
 #include <libdbc/dbc.hpp>
+#include <string>
 
 TEST_CASE("Testing dbc file loading error issues", "[fileio][error]") {
 	auto parser = std::unique_ptr<libdbc::DbcParser>(new libdbc::DbcParser());
@@ -28,10 +29,10 @@ TEST_CASE("Testing dbc file loading error issues", "[fileio][error]") {
 
 	SECTION("Verify that what() method is accessible for all exceptions", "[error]") {
 		auto generic_error = libdbc::exception();
-		REQUIRE(generic_error.what() == "libdbc exception occurred");
+		REQUIRE(std::string{generic_error.what()} == "libdbc exception occurred");
 
 		auto validity_check = libdbc::validity_error();
-		REQUIRE(validity_check.what() == "Invalid DBC file");
+		REQUIRE(std::string{validity_check.what()} == "Invalid DBC file");
 	}
 }
 

test/test_parseMessage.cpp

@@ -24,7 +24,7 @@ BO_ 123 MSG2: 8 Vector__XXX
 
 	parser.parse_file(filename);
 
-	SECTION("Evaluating unknown message id") {
+	SECTION("Evaluating unknown` message id") {
 		std::vector<double> out_values;
 		CHECK(parser.parseMessage(578, std::vector<uint8_t>({0xFF, 0xA2}), out_values) == libdbc::Message::ParseSignalsStatus::ErrorUnknownID);
 	}
@@ -54,7 +54,7 @@ TEST_CASE("Parse Message Big Number not aligned little endian") {
 		std::vector<double> refData{2, 0, 0, 1, 0, 0, 0};
 		CHECK(refData.size() == 7);
 		CHECK(out_values.size() == refData.size());
-		for (int i = 0; i < refData.size(); i++) {
+		for (size_t i = 0; i < refData.size(); i++) {
 			CHECK(out_values.at(i) == refData.at(i));
 		}
 	}
@@ -65,7 +65,7 @@ TEST_CASE("Parse Message Big Number not aligned little endian") {
 		std::vector<double> refData{3, 32, 0, 1, 0, 0, 47};
 		CHECK(refData.size() == 7);
 		CHECK(out_values.size() == refData.size());
-		for (int i = 0; i < refData.size(); i++) {
+		for (size_t i = 0; i < refData.size(); i++) {
 			CHECK(out_values.at(i) == refData.at(i));
 		}
 	}
@@ -76,7 +76,7 @@ TEST_CASE("Parse Message Big Number not aligned little endian") {
 		std::vector<double> refData{3, 51, 0, 1, 0, 0, 57};
 		CHECK(refData.size() == 7);
 		CHECK(out_values.size() == refData.size());
-		for (int i = 0; i < refData.size(); i++) {
+		for (size_t i = 0; i < refData.size(); i++) {
 			CHECK(out_values.at(i) == refData.at(i));
 		}
 	}