feat(session): add SUNSHINE_CLIENT_NAME environment variable - #5465
Merged
ReenigneArcher merged 4 commits intoAug 30, 2026
Conversation
ReenigneArcher
force-pushed
the
feat/client-name-env
branch
from
August 30, 2026 13:53
20f15e8 to
54a31ba
Compare
|
ReenigneArcher
approved these changes
Aug 30, 2026
Bundle ReportChanges will increase total bundle size by 71 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5465 +/- ##
==========================================
- Coverage 33.91% 33.90% -0.01%
==========================================
Files 104 104
Lines 25193 25197 +4
Branches 11146 11151 +5
==========================================
- Hits 8543 8542 -1
- Misses 13652 15537 +1885
+ Partials 2998 1118 -1880
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 55 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #5465 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR populates a new environment variable, "SUNSHINE_CLIENT_NAME", with the friendly name given for the client cert during the PIN pairing process.
The use case for this is being able to reference specific clients in host scripts. For example, if "Justin-TV" should get a different HDR calibration setting in KDE Plasma than "Justin-Macbook" I can match on the client name to set it instead of the requested height/width (which works until you have more than one device requesting the same resolution).
I've tested this on my own devices:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
Unit tests were run and reviewed for potential updates but I couldn't think of a reasonable way to cover this change.
AI Usage
See our AI usage policy.
Web-based AI helped with brainstorming where to implement the change and then I promptly ignored its recommendations and came up with a solution I liked better. No AI ever touched the coding environment.