feat(input): update libvirtualhid integration - #5563
Merged
Conversation
Renamed the license-state refresh flow from mouse-only to shared virtual input so Sunshine now recreates both libvirtualhid keyboard and mouse devices, including resetting keyboard/mouse state before refresh. Added explicit keyboard refresh support in the virtualhid input context and wired config HTTP license updates to trigger the full refresh. Updated Windows-facing messaging and docs to describe Raw Input keyboard + mouse support, added troubleshooting guidance for keyboard detection, and adjusted tray/UI localization strings accordingly. Also bumped the minimum supported Virtual HID Driver version to 2026.826.2024.22, updated related unit tests, and advanced the libvirtualhid submodule.
Bundle ReportChanges will increase total bundle size by 91 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
|
Build artifactsArtifacts from workflow run 33283016496:
You must be signed in to GitHub to download workflow artifacts. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5563 +/- ##
==========================================
+ Coverage 33.65% 33.91% +0.25%
==========================================
Files 104 104
Lines 25125 25193 +68
Branches 11118 11145 +27
==========================================
+ Hits 8457 8543 +86
- Misses 13824 15635 +1811
+ Partials 2844 1015 -1829
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #5563 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
ReenigneArcher
force-pushed
the
feat/libvirtualhid-updates
branch
from
August 28, 2026 01:16
596fbf9 to
91434da
Compare
Introduce a new gamepad feedback path for player indicator LEDs, including a new feedback message type, control-stream packet encoding (0x5504), and virtual HID output handling with deduplication of repeated LED states. Broaden controller extension capability detection from touchpad-only to touchpad-or-motion and use it consistently across Linux, macOS, and Windows capability reporting. Update unit tests to cover both touchpad support and controller extension advertising, plus player LED routing/dedup behavior, and bump the libvirtualhid submodule.
ReenigneArcher
force-pushed
the
feat/libvirtualhid-updates
branch
from
August 28, 2026 15:51
91434da to
923eb82
Compare
ReenigneArcher
changed the title
ReenigneArcher
marked this pull request as ready for review
August 28, 2026 16:50
This was referenced Aug 28, 2026
ReenigneArcher
marked this pull request as draft
August 28, 2026 19:39
ReenigneArcher
force-pushed
the
feat/libvirtualhid-updates
branch
12 times, most recently
from
August 29, 2026 15:10
13e5b36 to
735842d
Compare
ReenigneArcher
force-pushed
the
feat/libvirtualhid-updates
branch
from
August 29, 2026 17:25
735842d to
2ab80c8
Compare
Extend udev rule reloading to cover hidraw and input subsystems so permissions are applied to dynamically created libvirtualhid gamepad child nodes, not just /dev/uinput and /dev/uhid. Also: - Always install the udev rules file regardless of whether libudev is detected at build time - Add Homebrew postinst support to copy rules to host-monitored directories - Trigger udevadm reload on rule removal (AppImage, Flatpak) - Update comments to say "gamepad emulation" instead of "DS5 emulation" - Add docs clarifying that manual chmod/setfacl changes are lost on reconnect and how to reload rules
ReenigneArcher
force-pushed
the
feat/libvirtualhid-updates
branch
from
August 29, 2026 21:46
67945fd to
50c5419
Compare
Raise the minimum supported Virtual HID Driver version to `2026.829.2338.54` in config HTTP status output, update the related unit test expectations, and sync the Getting Started and Troubleshooting docs. The embedded `libvirtualhid` submodule is also updated to match the newer Windows control and broker protocol requirements.
ReenigneArcher
marked this pull request as ready for review
August 30, 2026 00:25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.