fix: Make system strings translatable

Author: jissereitsma

view/adminhtml/templates/form/field_type/entity_select.phtml

@@ -80,13 +80,13 @@ $fieldId = $field->getDomId();
                 <div class="modal-inner-wrap" style="padding:20px;">
                     <header class="modal-header">
                         <h1 class="modal-title" data-role="title">
-                            <?= $escaper->escapeHtml($modalTitle) ?>
+                            <?= $escaper->escapeHtml(__($modalTitle)) ?>
                         </h1>
                         <button
                             @click="closeWrapper"
                             class="action-close"
                             type="button">
-                            <span>Close</span>
+                            <span><?= __('Close') ?></span>
                         </button>
 
 
@@ -101,12 +101,12 @@ $fieldId = $field->getDomId();
                                     type="text"
                                     :value="search"
                                     @keyup="setSearch"
-                                    placeholder="Search by keyword"
-                                    aria-label="Search by keyword"
+                                    placeholder="<?= __('Search by keyword') ?>"
+                                    aria-label="<?= __('Search by keyword') ?>"
                                 />
 
-                                <button class="action-submit" type="button" aria-label="Search">
-                                    <span>Search</span>
+                                <button class="action-submit" type="button" aria-label="<?= __('Search') ?>">
+                                    <span><?= __('Search') ?></span>
                                 </button>
                             </div>
                         </div>
@@ -145,7 +145,7 @@ $fieldId = $field->getDomId();
                             <template x-if="hasNoEntities">
                                 <tr class="data-row">
                                     <td class="data-grid-cell" colspan="<?= count($columns) + 1 ?>">
-                                        No items found
+                                        <?= __('No items found') ?>
                                     </td>
                                 </tr>
                             </template>

view/adminhtml/templates/form/field_type/product_id.phtml

@@ -27,7 +27,7 @@ $fieldId = $field->getDomId();
 ?>
 <select
     id="<?= $escaper->escapeHtml($fieldId) ?>"
-    aria-label="<?= $escaper->escapeHtml($field->getLabel()) ?>"
+    aria-label="<?= $escaper->escapeHtml(__($field->getLabel())) ?>"
     class="admin__control-select"
     name="<?= $escaper->escapeHtml($field->getCode()) ?>"
     data-name="<?= $escaper->escapeHtml($field->getCode()) ?>"

view/adminhtml/templates/form/field_type/select.phtml

@@ -25,7 +25,7 @@ $fieldId = $field->getDomId();
 ?>
 <select
     id="<?= $escaper->escapeHtml($fieldId) ?>"
-    aria-label="<?= $escaper->escapeHtml($field->getLabel()) ?>"
+    aria-label="<?= $escaper->escapeHtml(__($field->getLabel())) ?>"
     class="admin__control-select"
     name="<?= $escaper->escapeHtml($field->getCode()) ?>"
     data-name="<?= $escaper->escapeHtml($field->getCode()) ?>"

view/adminhtml/templates/grid/view-selector.phtml

@@ -1,21 +1,21 @@
 <div class="admin__action-dropdown-wrap admin__data-grid-action-bookmarks">
     <button class="admin__action-dropdown" type="button" @click="toggleViewSelector">
-        <span class="admin__action-dropdown-text">Default View</span>
+        <span class="admin__action-dropdown-text"><?= __('Default View') ?></span>
     </button>
     <ul class="admin__action-dropdown-menu" x-show="showViewSelector">
         <li>
             <div class="action-dropdown-menu-item">
-                <a class="action-dropdown-menu-link">Default View</a>
+                <a class="action-dropdown-menu-link"><?= __('Default View') ?></a>
             </div>
         </li>
 
         <li class="action-dropdown-menu-action action-dropdown-menu-item-last" style="display: none;">
-            <a href="">Save View As...</a>
+            <a href=""><?= __('Save View As...') ?></a>
             <div class="action-dropdown-menu-item-edit" style="display: none;">
-                <input id="new-view" class="admin__control-text" type="text" aria-label="New View">
+                <input id="new-view" class="admin__control-text" type="text" aria-label="<?= __('New View') ?>">
                 <div class="action-dropdown-menu-item-actions">
-                    <button class="action-submit" type="button" title="Save all changes">
-                        <span>Submit</span>
+                    <button class="action-submit" type="button" title="<?= __('Save all changes') ?>">
+                        <span><?= __('Submit') ?></span>
                     </button>
                 </div>
             </div>