Skip to content

Commit 241825f

Browse files
committed
security: Rewrite x-html to x-text because of CSP
1 parent 7e299cb commit 241825f

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

view/adminhtml/templates/form/field_type/entity_select.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ $fieldId = $field->getDomId();
6363
:value="<?= $escaper->escapeHtml($valueCode) ?>"
6464
@change="<?= $escaper->escapeHtml($field->getAlpineSetter()) ?>"
6565
>
66-
<span style="float: right; color: #777; font-size: 80%;" x-html="previewValue"></span>
66+
<span style="float: right; color: #777; font-size: 80%;" x-text="previewValue"></span>
6767
</span>
6868

6969
<button @click="showModalWrapper"><?= $escaper->escapeHtml(__($buttonLabel)) ?></button>
@@ -136,7 +136,7 @@ $fieldId = $field->getDomId();
136136
</td>
137137
<?php foreach ($columns as $column) : ?>
138138
<td class="data-grid-cell">
139-
<div class="data-grid-cell-content" x-html="entity.<?= $escaper->escapeHtml($column->getCode()) ?>"></div>
139+
<div class="data-grid-cell-content" x-text="entity.<?= $escaper->escapeHtml($column->getCode()) ?>"></div>
140140
</td>
141141
<?php endforeach; ?>
142142
</tr>

view/adminhtml/templates/form/field_type/view.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ $field = $block->getField();
1919
$fieldType = $field->getFieldType();
2020

2121
?>
22-
<div style="padding-top:8px;" x-html="<?= $escaper->escapeHtml($field->getScope()) ?>.<?= $escaper->escapeHtml($field->getCode()) ?>"></div>
22+
<div style="padding-top:8px;" x-text="<?= $escaper->escapeHtml($field->getScope()) ?>.<?= $escaper->escapeHtml($field->getCode()) ?>"></div>

view/adminhtml/templates/grid/pager/pagination.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ $page = $viewModel->getPage();
3030
id="current_page"/>
3131

3232
<label class="admin__control-support-text" for="current_page">
33-
of <span x-html="totalPages"></span> pages
33+
of <span x-text="totalPages"></span> pages
3434
</label>
3535

3636
<button

view/adminhtml/templates/grid/records.phtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ use Magento\Framework\View\Element\Template;
1010
/** @var Template $block */
1111
?>
1212
<div class="admin__control-support-text">
13-
<span x-html="totalItems"></span> <?= $escaper->escapeHtml(__('records found')) ?>
13+
<span x-text="totalItems"></span> <?= $escaper->escapeHtml(__('records found')) ?>
1414

1515
<span x-cloak x-show="getSelectedIdCount">
16-
(<span x-html="getSelectedIdCount"></span> selected)
16+
(<span x-text="getSelectedIdCount"></span> selected)
1717
</span>
1818
</div>

0 commit comments

Comments
 (0)