Repository navigation
feat: drop layout-helper and codepush, move analytics to modular fire… - #16
Merged
Merged
Conversation
…base Vendor chrome is sized in plain points instead of percentages of the screen. The numbers are the ones the call sites already carried in comments, so rendering is unchanged on any screen at or above 375x812. flat-list/empty gains style props, the only sizing with no override path. wp(100) in screen-animation meant the full screen width, not 100pt, and now reads it from Dimensions. CodePush is gone: App Center was retired in March 2025, so the store kept a dependency that can no longer deliver an update. The reload button in ErrorBoundary drops the error state instead of restarting. Analytics calls the modular Firebase API, which unblocks @react-native-firebase v22, where the namespaced accessor is removed. Platform checks move to an internal helpers/platform, so Platform.OS is read in exactly one place. BREAKING CHANGE: AppVersionStore.addSubscribes(), codepushVersion and setCodepushVersion() are removed, and versionOutput no longer carries the codepush suffix. react-native-code-push is no longer a peer dependency. Vendor component sizes are fixed points and no longer scale on screens narrower than 375pt or shorter than 812pt. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…base
Vendor chrome is sized in plain points instead of percentages of the screen. The numbers are the ones the call sites already carried in comments, so rendering is unchanged on any screen at or above 375x812. flat-list/empty gains style props, the only sizing with no override path. wp(100) in screen-animation meant the full screen width, not 100pt, and now reads it from Dimensions.
CodePush is gone: App Center was retired in March 2025, so the store kept a dependency that can no longer deliver an update. The reload button in ErrorBoundary drops the error state instead of restarting.
Analytics calls the modular Firebase API, which unblocks @react-native-firebase v22, where the namespaced accessor is removed.
Platform checks move to an internal helpers/platform, so Platform.OS is read in exactly one place.
BREAKING CHANGE: AppVersionStore.addSubscribes(), codepushVersion and setCodepushVersion() are removed, and versionOutput no longer carries the codepush suffix. react-native-code-push is no longer a peer dependency. Vendor component sizes are fixed points and no longer scale on screens narrower than 375pt or shorter than 812pt.