removed unsused + duplicate code

Author: spotta85

features/audit/audit-provider.tsx

@@ -4,8 +4,6 @@ import type {
   AuditRequirement,
   CachedAuditData,
   CompositeAuditData,
-  CompositeAuditRequirement,
-  DuplicateCourseRequirementFlag,
 } from "@/domain/audit";
 import type {
   Course,
@@ -18,7 +16,6 @@ import { usePreferences } from "@/features/preferences/preferences-provider";
 import {
   calculateWeightedDegreeCompletion,
   getCompositeAuditRequirements,
-  getDuplicateCourseRequirementFlags,
 } from "@/lib/audit-calculations";
 import {
   getAuditData,
@@ -39,10 +36,6 @@ type SemesterInfo = Record<StringSemester, Course[]>;
 
 interface AuditContextValue {
   sections: AuditRequirement[];
-  courses: Course[];
-  compositeAuditData: CompositeAuditData;
-  compositeRequirements: CompositeAuditRequirement[];
-  duplicateCourseFlags: DuplicateCourseRequirementFlag[];
   history: AuditHistoryData;
   currentAuditId: string;
   currentAudit: AuditHistoryEntry;
@@ -61,8 +54,6 @@ interface AuditContextValue {
     requirementTitle: string,
     ruleTitle: string,
   ) => Promise<CourseId | null>;
-  removePlannedCourse: (courseId: CourseId) => Promise<boolean>;
-  wipeAllPlannedCourses: () => Promise<number>;
 }
 
 const AuditContext = createContext<AuditContextValue | null>(null);
@@ -111,11 +102,6 @@ export function AuditContextProvider({
     [compositeAuditData],
   );
   const courseMap = auditData?.courses ?? {};
-  const compositeRequirements = sections;
-  const duplicateCourseFlags = useMemo(
-    () => getDuplicateCourseRequirementFlags(compositeAuditData),
-    [compositeAuditData],
-  );
   const progresses = useMemo(
     () => calculateWeightedDegreeCompletion(sections, courseMap),
     [courseMap, sections],
@@ -233,10 +219,6 @@ export function AuditContextProvider({
     <AuditContext.Provider
       value={{
         sections,
-        courses: Object.values(courseMap),
-        compositeAuditData,
-        compositeRequirements,
-        duplicateCourseFlags,
         history,
         semesters,
         currentAuditId,
@@ -256,8 +238,6 @@ export function AuditContextProvider({
         },
         courseMap,
         addPlannedCourse,
-        removePlannedCourse,
-        wipeAllPlannedCourses,
       }}
     >
       {children}

features/audit/components/audit-card.tsx

@@ -1,4 +1,3 @@
-import type { AuditHistoryEntry } from "@/domain/audit";
 import {
   CopySimple,
   DotsThree,
@@ -7,7 +6,9 @@ import {
 } from "@phosphor-icons/react";
 import React from "react";
 
-export interface DegreeAuditCardProps extends AuditHistoryEntry {
+export interface DegreeAuditCardProps {
+  title?: string;
+  percentage?: number;
   isSelected?: boolean;
   onToggle?: () => void;
   onRename?: (title: string) => void;
@@ -17,17 +18,15 @@ export interface DegreeAuditCardProps extends AuditHistoryEntry {
  * Sidebar variant - collapsible with caret icons and menu dots
  */
 const DegreeAuditCard: React.FC<DegreeAuditCardProps> = ({
-  title = "Degree Audit 1",
-  majors = ["Informatics", "Design"],
-  minors = ["Business"],
-  percentage = 90,
+  title,
+  percentage,
   isSelected = false,
   onToggle,
   onRename,
 }) => {
   const [menuOpen, setMenuOpen] = React.useState(false);
   const [isEditing, setIsEditing] = React.useState(false);
-  const [draftTitle, setDraftTitle] = React.useState(title);
+  const [draftTitle, setDraftTitle] = React.useState(title ?? "");
 
   React.useEffect(() => {
     if (!isSelected) {
@@ -43,12 +42,12 @@ const DegreeAuditCard: React.FC<DegreeAuditCardProps> = ({
     if (nextTitle && nextTitle !== title) {
       onRename?.(nextTitle);
     } else {
-      setDraftTitle(title);
+      setDraftTitle(title ?? "");
     }
   };
 
   const startRename = () => {
-    setDraftTitle(title);
+    setDraftTitle(title ?? "");
     setIsEditing(true);
     setMenuOpen(false);
   };

features/audit/components/graph.tsx

@@ -25,7 +25,7 @@ type GraphProps = GraphStyleProps & {
   children?: React.ReactNode;
   bars: Bar[];
   tooltipContent?: (bar: Bar) => React.ReactNode;
-} & GraphStyleProps;
+};
 
 function lowerOpacityColor(
   color: `rgb(${number}, ${number}, ${number})`,
@@ -50,7 +50,6 @@ type InnerDonutGraphStylingProps = {
 
 type InnerDonutGraphProps = {
   bar: Bar;
-  index: number;
   animatedProgress: number;
   animatedPlannedProgress: number;
   onMouseEnter: () => void;
@@ -176,7 +175,6 @@ const InnerDonutGraph = (props: InnerDonutGraphProps) => {
     bgOpacity = 0.1,
     ...other
   } = props;
-  // Calculate stroke-dasharray for circular progress
   const svgRef = useRef<SVGSVGElement>(null);
   const circumference = 2 * Math.PI * radius;
   const progressLength =
@@ -421,7 +419,6 @@ const MultiDonutGraph = (props: GraphProps) => {
           <InnerDonutGraph
             key={index}
             bar={bar}
-            index={index}
             radius={startRadius - index * (strokeWidth + gap)}
             color={bar.color}
             animatedProgress={animatedProgress[index]?.current || 0}

features/audit/components/requirement-breakdown.tsx

@@ -117,27 +117,12 @@ const RequirementBadge = ({
   );
 };
 
-const statusIcons = {
-  Completed: {
-    icon: null,
-    color: "bg-[#ECF8D0] border-[#9FCA5B]",
-  },
-  Planned: {
-    icon: null,
-    color: "bg-course-applied border-gray-200",
-  },
-  "In Progress": {
-    icon: null,
-    color: "bg-course-in-progress border-gray-200",
-  },
-  "Not Started": {
-    icon: null,
-    color: "bg-course-unknown border-gray-200",
-  },
-} as const satisfies Record<
-  PlannableStatus,
-  { icon: React.ReactNode | null; color: string }
->;
+const statusColors: Record<PlannableStatus, string> = {
+  Completed: "bg-[#ECF8D0] border-[#9FCA5B]",
+  Planned: "bg-course-applied border-gray-200",
+  "In Progress": "bg-course-in-progress border-gray-200",
+  "Not Started": "bg-course-unknown border-gray-200",
+};
 
 // Course pill component matching Figma design
 const CoursePill = ({ course }: { course: Course }) => {
@@ -148,7 +133,7 @@ const CoursePill = ({ course }: { course: Course }) => {
     <div
       className={cn(
         "grid grid-cols-[100px_1fr_auto] items-center gap-4 px-4 py-3 rounded-lg text-sm w-full border text-gray-900",
-        statusIcons[course.status].color,
+        statusColors[course.status],
       )}
     >
       <span className="font-semibold min-w-[80px]">{course.code}</span>

features/audit/components/sidebar.tsx

@@ -69,8 +69,6 @@ const Sidebar = () => {
                 <DegreeAuditCard
                   key={id}
                   title={audit.title}
-                  majors={audit.majors}
-                  minors={audit.minors}
                   percentage={audit.percentage}
                   isSelected={currentAuditId === id}
                   onToggle={() => {

features/catalog/components/course-add-modal.tsx

@@ -37,8 +37,6 @@ interface CourseAddModalProps {
 
 interface CourseSearchData {
   searchQuery: string;
-  requirement: string;
-  catalogYear: string;
   department: string;
   lowerDivision: boolean;
   upperDivision: boolean;
@@ -62,7 +60,6 @@ function waitForNextPaint(): Promise<void> {
 }
 
 interface CourseSearchContentProps {
-  recommendedCourses?: CatalogCourse[];
   onSearchSubmit?: (formData: CourseSearchData) => void | Promise<void>;
   isLoading?: boolean;
 }
@@ -104,19 +101,13 @@ function DivisionToggle({
 }
 
 function CourseSearchContent({
-  recommendedCourses,
   onSearchSubmit,
   isLoading = false,
 }: CourseSearchContentProps) {
-  const { recommendedCourses: sharedRecommendedCourses } =
-    useCourseModalContext();
-  const displayedRecommendedCourses = dedupeCatalogCoursesByCode(
-    recommendedCourses ?? sharedRecommendedCourses,
-  );
+  const { recommendedCourses } = useCourseModalContext();
+  const displayedRecommendedCourses = dedupeCatalogCoursesByCode(recommendedCourses);
   const [formData, setFormData] = useState<CourseSearchData>({
     searchQuery: "",
-    requirement: "",
-    catalogYear: "",
     department: "",
     lowerDivision: true,
     upperDivision: true,
@@ -505,17 +496,11 @@ export default function CourseAddModal({
 
   return (
     <div
-      className={cn(
-        "fixed inset-0 z-50 flex items-center justify-center transition-all duration-200",
-        isOpen ? "bg-black/50 opacity-100" : "opacity-0 pointer-events-none",
-      )}
+      className="fixed inset-0 z-50 flex items-center justify-center transition-all duration-200 bg-black/50 opacity-100"
       onClick={onClose}
     >
       <div
-        className={cn(
-          "bg-background rounded-md border border-dap-border shadow-2xl w-full max-w-[550px] max-h-[90vh] mx-4 transform transition-all duration-200 overflow-hidden",
-          isOpen ? "scale-100 opacity-100" : "scale-95 opacity-0",
-        )}
+        className="bg-background rounded-md border border-dap-border shadow-2xl w-full max-w-[550px] max-h-[90vh] mx-4 transform transition-all duration-200 overflow-hidden scale-100 opacity-100"
         onClick={(e) => e.stopPropagation()}
       >
         <div className="px-7 pt-7 pb-7">

features/catalog/course-modal-provider.tsx

@@ -18,7 +18,6 @@ interface CourseModalContextType {
   recommendedCourses: CatalogCourse[];
   recommendationScope: RecommendationScope | null;
   isLoadingRecommendedCourses: boolean;
-  toggleModal: () => void;
   openModal: (scope?: RecommendationScope) => void;
   closeModal: () => void;
 }
@@ -79,23 +78,24 @@ export const CourseModalContextProvider = ({
     recommendationScope?.ruleTitle,
   ]);
 
+  const closeModal = () => {
+    setIsOpen(false);
+    setRecommendationScope(null);
+  };
+
   return (
     <CourseModalContext.Provider
       value={{
         isOpen,
         recommendedCourses,
         recommendationScope,
         isLoadingRecommendedCourses,
-        toggleModal: () => setIsOpen(!isOpen),
         openModal: (scope) => {
           setRecommendedCourses([]);
           setRecommendationScope(scope ?? null);
           setIsOpen(true);
         },
-        closeModal: () => {
-          setIsOpen(false);
-          setRecommendationScope(null);
-        },
+        closeModal,
       }}
     >
       {children}
@@ -105,10 +105,7 @@ export const CourseModalContextProvider = ({
         recommendedCourses={recommendedCourses}
         recommendationScope={recommendationScope}
         isLoading={isLoadingRecommendedCourses}
-        onClose={() => {
-          setIsOpen(false);
-          setRecommendationScope(null);
-        }}
+        onClose={closeModal}
       />
     </CourseModalContext.Provider>
   );

lib/audit-calculations.ts

@@ -86,7 +86,6 @@ export function calculateWeightedDegreeCompletion(
     total: { current: 0, planned: 0, total: 0 },
     sections: [],
   };
-  console.log("sections", sections);
   sections.forEach((section) => {
     const sectionProgress = {
       title: section.title,
@@ -138,6 +137,5 @@ export function calculateWeightedDegreeCompletion(
     (acc, section) => acc + section.progress.total,
     0,
   );
-  console.log("[Audit Calculations] results", results);
   return results;
 }