Skip to content

Add LAContext newInstanceId/newCommandId counter race reproduction - #2

Merged
LucaCappelletti94 merged 1 commit into
add/result-record-toolingfrom
add/lacontext-counter-race
Oct 12, 2026
Merged

LucaCappelletti94 merged 1 commit into
add/result-record-toolingfrom
add/lacontext-counter-race

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

LAContext construction and most of its methods take an ID from two process-wide counters that Apple increments with a plain load, add, and store, no lock or atomic instruction. Two threads that each create and use only their own context can still race on those counters and end up sharing an instance ID. Filed with Apple as FB25157108, and discussed on madsmtm/objc2#864.

Two independently captured runs are included, one on the bare host and one inside a VM, both landing on the same macOS build, so the result does not rest on a single run's luck. A monthly workflow reruns it against the three macOS majors still receiving Apple's security patches and records a fresh result if anything changes.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

  • 馃攳 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

鈿欙笍 Run configuration
  • Configuration used: Repository: LucaCappelletti94/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a3076f15-ec8c-4192-8e90-eacf0b437d55

  • Autofix 路 Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

@LucaCappelletti94
LucaCappelletti94 added this pull request to stack #4 October 12, 2026 18:33
@LucaCappelletti94
LucaCappelletti94 merged commit 637b8ed into main Oct 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant