Repository navigation
Add LAContext newInstanceId/newCommandId counter race reproduction - #2
Merged
LucaCappelletti94 merged 1 commit intoOct 12, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LucaCappelletti94
added this pull request to stack #4
October 12, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LAContext construction and most of its methods take an ID from two process-wide counters that Apple increments with a plain load, add, and store, no lock or atomic instruction. Two threads that each create and use only their own context can still race on those counters and end up sharing an instance ID. Filed with Apple as FB25157108, and discussed on madsmtm/objc2#864.
Two independently captured runs are included, one on the bare host and one inside a VM, both landing on the same macOS build, so the result does not rest on a single run's luck. A monthly workflow reruns it against the three macOS majors still receiving Apple's security patches and records a fresh result if anything changes.