fix(table-skeleton): colsAlign index start at 1 - #5246
Merged
Merged
Conversation
ymalie-lucca
added
💥 Breaking change
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5246/index.html |
Contributor
|
Can you give us a bit more details on why this is needed please? We use 0-based indexes everywhere, using 1 just here feels wrong. |
Contributor
Author
|
@Supamiu I already discussed this with Jérémie a couple of months ago, it's so uncomfortable when I know that the fourth column of the table needs to be aligned to the right. I have to think about how it's calculated in the component code, then subtract one to set the correct value that matches the code logic rather than the human reading logic. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The breaking behavior needs an explicit one-based API description and a component changelog entry.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates table skeletons so colsAlign uses one-based column numbers.
Changes:
- Generates column identifiers from
1throughcols. - Updates templates and examples for one-based alignment keys.
- Adds
colsAligninput documentation.
File summaries
| File | Description |
|---|---|
stories/qa/skeleton-components/skeleton-components.stories.html |
Updates QA examples. |
stories/documentation/loaders/skeleton-table/angular/skeleton-table.stories.ts |
Updates table documentation. |
stories/documentation/loaders/skeleton-table/angular/skeleton-table-body.stories.ts |
Updates body-only example. |
stories/documentation/loaders/skeleton-index-table/angular/skeleton-index-table.stories.ts |
Updates index-table documentation. |
stories/documentation/loaders/skeleton-index-table/angular/skeleton-index-table-body.stories.ts |
Updates body-only example. |
stories/documentation/loaders/skeleton-data-table/angular/skeleton-data-table.stories.ts |
Updates data-table documentation. |
stories/documentation/loaders/skeleton-data-table/angular/skeleton-data-table-body.stories.ts |
Updates body-only example. |
packages/ng/skeleton/skeleton-table/skeleton-table.component.ts |
Generates one-based column numbers. |
packages/ng/skeleton/skeleton-table/skeleton-table.component.html |
Uses column numbers for alignment. |
packages/ng/skeleton/skeleton-index-table/skeleton-index-table.component.ts |
Generates one-based column numbers. |
packages/ng/skeleton/skeleton-index-table/skeleton-index-table.component.html |
Uses column numbers for alignment. |
packages/ng/skeleton/skeleton-data-table/skeleton-data-table.component.ts |
Generates one-based column numbers. |
packages/ng/skeleton/skeleton-data-table/skeleton-data-table.component.html |
Uses column numbers for alignment. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 4
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeremie-lucca
force-pushed
the
fix/table-skeleton/colsalign-index
branch
from
September 17, 2026 14:51
8de19c7 to
d854cf1
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jeremie-lucca
had a problem deploying
to
staging
September 17, 2026 14:53 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jeremie-lucca
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🔥 Breaking
The
colsAlignkeys onlu-skeleton-table,lu-skeleton-index-tableandlu-skeleton-data-tableare now column numbers starting at1instead of0-based indexes.Increment every key by one:
{ 0: 'center', 1: 'end' }becomes{ 1: 'center', 2: 'end' }.