Skip to content

feat(tooltip, popover2): Share the overlay focus-return suppression - #5272

Draft
fbasmaison-lucca wants to merge 1 commit into
release/22.1from
feature/tooltip-focus-monitor-variant
Draft

feat(tooltip, popover2): Share the overlay focus-return suppression#5272
fbasmaison-lucca wants to merge 1 commit into
release/22.1from
feature/tooltip-focus-monitor-variant

Conversation

@fbasmaison-lucca

@fbasmaison-lucca fbasmaison-lucca commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

focusSilently focuses a trigger without revealing its tooltip or its popover.

Contribution

  • Designs are respected and all relevant options are handled
  • Responsive behavior addressed when needed
  • Feature is accessible (keyboard navigation, screen reader support, ARIA tags, etc.)
  • Stories are updated and Storybook controls have descriptions
  • Feature is covered by E2E tests or UI diff
  • npm run build OK
  • npm run lint OK

Functional review

  • UI diff OK
  • Feature and all options are manually tested and comply with design and guidelines.

@fbasmaison-lucca fbasmaison-lucca added 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.) 🤖 Produced by AI Some code was produced by AI. (Autocompleted code doesn't require to be labeled) labels Aug 25, 2026
@c-3po c-3po Bot added the 📖 Documentation changes Requires a Prisme update label Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5272/index.html

@JeSuisCharlie1
JeSuisCharlie1 force-pushed the feature/tooltip-not-on-overlay-focus-return branch from 2619636 to 8b5b8f0 Compare August 31, 2026 14:01
Base automatically changed from feature/tooltip-not-on-overlay-focus-return to release/22.0 September 1, 2026 07:48
@fbasmaison-lucca @claude
feat(tooltip, popover2): Share the overlay focus-return suppression:
6c6ef3d 
* Extract the detection into `ɵintentionalFocus$`, driven by the CDK `FocusMonitor`.
* Add `focusSilently` for an application moving the focus itself.
* Require both a `program` origin and a return from a foreign overlay pane.
* Restore the popover2 trigger focus through a `program` origin.
* Drop the popover2 `#skipNextFocus` flag.
* Drop the tooltip `(focus)` and `(focusout)` host listeners.
* Cover both components with focus-return story tests.

Co-Authored-By: Claude <noreply@anthropic.com>
@fbasmaison-lucca
fbasmaison-lucca force-pushed the feature/tooltip-focus-monitor-variant branch from 0723ebf to 6c6ef3d Compare September 1, 2026 13:42
@jeremie-lucca
jeremie-lucca changed the base branch from release/22.0 to release/22.1 September 9, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

📖 Documentation changes Requires a Prisme update 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.) 🤖 Produced by AI Some code was produced by AI. (Autocompleted code doesn't require to be labeled)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fbasmaison-lucca