Conversation
Below the `S` breakpoint (800px), simple, multi and tree selects open their panel as a full-width bottom sheet pinned to the viewport edge (solid backdrop, blocked page scroll, slide-up) instead of a popover anchored to the field. Mirroring filter pills, the sheet embeds its own search input, with the field label as a title, a close button and a leading search icon, while the field stays in the form, covered by the backdrop. Filter-pill selects keep their existing overlay and desktop (>= S) is unchanged. Closes #2495 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Supamiu
added
🔖✨ Feature
Supamiu
changed the title
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5313/index.html |
c-3po
Bot
added
the
🔨 Technical
JeSuisCharlie1
previously approved these changes
Sep 14, 2026
Supamiu
commented
Sep 17, 2026
Comment on lines
+74
to
+75
| style.setProperty('--components-dialog-visibleViewportHeight', `${viewport.height}px`); | ||
| style.setProperty('--components-dialog-visibleViewportBottomOffset', `${window.innerHeight - viewport.height - viewport.offsetTop}px`); |
Contributor
Author
There was a problem hiding this comment.
Wouldn't this affect existing dialogs too? Say we have a select inside a dialog, because it's a generic var, I assume it's used by every dialog.
Contributor
There was a problem hiding this comment.
I'm pushing one more commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select now opens in a dialog when display it too small.
Partially made with Claude, especially for the base structure, as it's basically "reuse what I did for filter pill but on a dialog".
I opened a draft so we can check for conflicts and have a public storybook to play with
Optionally, technical or more in-depth description for reviewers.
Keep an empty line under your text, as well as the 5 lines that follow it.