test(dialog): cover dialog stories with e2e test - #5356
Merged
Merged
Conversation
JeSuisCharlie1
added
the
🔨 Technical
JeSuisCharlie1
added
the
🤖 Produced by AI
34 tasks
|
🚀 Storybook preview deployed: https://pub-dc6d99acd6874e2aaff6219dd8a13ae2.r2.dev/PR-5356/index.html |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Storybook E2E interaction coverage for dialog service, routing, confirmation, and close-guard scenarios.
Changes:
- Adds mouse and keyboard dialog interaction tests.
- Covers closing behavior, routing callbacks, stacking, and
canClosevariants.
File summaries
| File | Description |
|---|---|
| stories/documentation/overlays/dialog/dialog-service.stories.ts | Updated as part of this pull request. |
| stories/documentation/overlays/dialog/dialog-routing.stories.ts | Updated as part of this pull request. |
| stories/documentation/overlays/dialog/dialog-confirmation.stories.ts | Updated as part of this pull request. |
| stories/documentation/overlays/dialog/dialog-canClose.stories.ts | Updated as part of this pull request. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| await step('Navigating to the dialog route opens it with the data from its factory', async () => { | ||
| const dialog = await openRoutedDialog(); | ||
| await expect(within(dialog).getByRole('heading', { name: 'Dialog opened by route' })).toBeVisible(); |
Comment on lines
+228
to
+231
| await step('Escape is ignored, as it goes through the same stream as the backdrop click', async () => { | ||
| await userEvent.keyboard('{Escape}'); | ||
| await expectStillOpen(); | ||
| }); |
jeremie-lucca
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Storybook interaction tests to the dialog stories :
I added a section to the test doc to cover the remaining missing E2E tests!