Skip to content

[15.x] Fail the release when the tag is not on its release branch - #4669

Merged
jbogard merged 2 commits into
release/15.xfrom
ci/verify-release-tag-branch-15x
Oct 26, 2026
Merged

jbogard merged 2 commits into
release/15.xfrom
ci/verify-release-tag-branch-15x

Conversation

@jbogard

@jbogard jbogard commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Before building, the release workflow now checks that the tagged commit is on the right branch: release/<major>.x if that branch exists, otherwise main. If it isn't, the release fails before anything is built, signed or pushed to NuGet.

Why

In #4620, v15.1.1 and v15.1.2 were created through the GitHub Releases UI. Entering the tag name before picking the branch creates the tag on the default branch, so both "15.x" packages were built from 16.x code (main at 1af71bfe). The UI makes this mistake easy to repeat, and nothing in the pipeline caught it.

How

  • The step runs right after checkout in the first release job. The publishing job needs that job, so a failed check stops the release.
  • The tag's major version picks the branch, so v15.* requires release/15.x. If a release/16.x branch is ever created, v16.* tags will then require it automatically.
  • The step uses shell: bash, which also works on the Windows runner.
  • On failure, the error says which branch the tag should be on.

Verification

I ran the same script locally against existing tags:

Tag Result
v15.1.1 ❌ not on release/15.x
v15.1.2 ❌ not on release/15.x
v15.1.3 ✅ on release/15.x
v16.2.0 ✅ on main
v16.0.0-beta-1 ✅ on main

Workflow YAML parses, and job dependencies are unchanged.

Companion PR for main: #4668

🤖 Generated with Claude Code

A tag created from the GitHub Releases UI can land on the default branch
instead of the selected one, which is how v15.1.1 and v15.1.2 were built
from 16.x code (#4620). Before building, verify the tagged commit is on
release/<major>.x when that branch exists, otherwise on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T22:13:10.789405Z 06e094a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

git ls-remote --exit-code returns 2 for no matching refs and 128 for a
failed lookup. Treating any failure as "no release branch" could let a
transient error pass a v15.* tag on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jbogard
jbogard merged commit 24ae647 into release/15.x Oct 26, 2026
2 checks passed
@jbogard
jbogard deleted the ci/verify-release-tag-branch-15x branch October 26, 2026 22:18
AngeloDotNet added a commit to AngeloDotNet/CloudBudget that referenced this pull request Nov 16, 2026
Updated [AutoMapper](https://github.com/LuckyPennySoftware/AutoMapper)
from 15.1.3 to 15.1.4.

<details>
<summary>Release notes</summary>

_Sourced from [AutoMapper's
releases](https://github.com/LuckyPennySoftware/AutoMapper/releases)._

## 15.1.4

## Security

This release fixes two denial-of-service vulnerabilities. In both,
deeply nested input could bypass `MaxDepth` and exhaust the stack. The
resulting `StackOverflowException` can't be caught, so it ends the
process. Please upgrade if your application maps untrusted, deeply
nested data.

-
[GHSA-6vhm-j9h7-f9gh](GHSA-6vhm-j9h7-f9gh):
`MaxDepth` wasn't enforced when mapping through constructor parameters,
including positional records. Thanks to @​mcambria for the report.
-
[GHSA-gpwp-5797-mjff](GHSA-gpwp-5797-mjff):
other recursion paths bypassed `MaxDepth`: derived maps, `object` and
interface members, dictionary and dynamic sources, and recursive type
converters.

CVE IDs have been requested and will be added here once they're
assigned.

## Behavior changes

- Recursion that `MaxDepth` can't limit now throws a catchable
`InsufficientExecutionStackException` instead of crashing the process.
- Derived maps (`Include` / `IncludeBase`) now inherit `MaxDepth` and
get the default limit of 64 for self-referential maps. If your
polymorphic graphs legitimately go deeper, set `MaxDepth` explicitly.
- Constructor mapping now stops at the same depth as property mapping.

## Other fixes

- Fixed `Context.Items are only available...` exceptions with
`MaxDepth`, which depended on registration or warmup order (#​4651,
backported in #​4676)

## What's Changed
* [15.x] Fail the release when the tag is not on its release branch by
@​jbogard in LuckyPennySoftware/AutoMapper#4669
* [15.x] Emit the context check for the containing type map in
CollectionMapper by @​jbogard in
LuckyPennySoftware/AutoMapper#4676
* [15.x] Run unit tests on .NET Framework in CI by @​jbogard in
LuckyPennySoftware/AutoMapper#4678


**Full Changelog**:
LuckyPennySoftware/AutoMapper@v15.1.3...v15.1.4

Commits viewable in [compare
view](LuckyPennySoftware/AutoMapper@v15.1.3...v15.1.4).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=AutoMapper&package-manager=nuget&previous-version=15.1.3&new-version=15.1.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/AngeloDotNet/CloudBudget/network/alerts).

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant