Skip to content

Commit 1d4d79f

Browse files
sbryngelsonclaude
andcommitted
ci: fix stale comments from incremental refactoring
- select-gpu-partition.sh: priority comment said 'smaller/older' but list is now L40S/H200/H100/A100/V100 - submit-slurm-job.sh: 'Idempotent' → 'Rerun-safe' (it always submits a new job) - bench.sh: n_jobs only used for build, not bench Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 698bd2e commit 1d4d79f

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/scripts/select-gpu-partition.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
# Select the best available Phoenix GPU partition using sinfo.
33
# Sources into caller: exports SELECTED_GPU_PARTITION.
44
#
5-
# Priority order prefers smaller/older nodes to leave modern GPUs free
6-
# for production workloads. Falls back to gpu-l40s if nothing is idle.
5+
# Priority order prefers partitions most likely to have availability.
6+
# V100 is last due to slower performance near the test time limit.
7+
# Falls back to gpu-l40s if no partition meets the idle node threshold.
78
# RTX 6000 nodes are excluded (too slow for the test suite time limit).
89
#
910
# Optional: set GPU_PARTITION_MIN_NODES before sourcing to require a minimum

.github/scripts/submit-slurm-job.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/bash
22
# Unified SLURM job submission and monitoring for all clusters.
33
# Submits a script as a SLURM batch job, then monitors it until completion.
4-
# Idempotent: cancels stale jobs from previous runs before resubmission.
4+
# Rerun-safe: cancels stale jobs from previous runs before resubmission.
55
#
66
# Usage: submit-slurm-job.sh <script.sh> <cpu|gpu> <none|acc|omp> <cluster> [shard]
77

.github/workflows/common/bench.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ set -euo pipefail
88
source .github/scripts/bench-preamble.sh
99

1010
# Cap parallel jobs at 64 to avoid overwhelming MPI daemons on large nodes
11-
# (GNR nodes have 192 cores but nproc is too aggressive for build/bench).
11+
# (GNR nodes have 192 cores but nproc is too aggressive for build).
1212
n_jobs=$(( $(nproc) > 64 ? 64 : $(nproc) ))
1313

1414
# --- Phoenix TMPDIR setup ---

0 commit comments

Comments
 (0)